Created attachment 218363 [details] [review]
core,renderer: Extract base class for libraries

Created attachment 218364 [details] [review]
core,server,examples,doc: Add librygel-server

Review of attachment 218363 [details] [review]:

Wht makes simple device 'simple'? Its an abstract class so can't be used as simple utility class. I suggest following hierarchy:

MediaDevice -> MediaServer
            -> MediaRenderer

::: src/librygel-renderer/rygel-playbin-renderer.vala
@@ -84,1 +66,1 @@
      * @param title Friendly name of the new UPnP renderer on the network.

doc for pipeline param as well?

Review of attachment 218364 [details] [review]:

I'm a bit confused. how does the rygel process now build/work?

(In reply to comment #3)
> Review of attachment 218363 [details] [review]:
> 
> Wht makes simple device 'simple'? Its an abstract class so can't be used as
> simple utility class. I suggest following hierarchy:

It was meant for "Simple" device creation taking away the need of creating a RootDeviceFactory etc. 

> 
> MediaDevice -> MediaServer
>             -> MediaRenderer

But that makes more sense.

> 
> ::: src/librygel-renderer/rygel-playbin-renderer.vala
> @@ -84,1 +66,1 @@
>       * @param title Friendly name of the new UPnP renderer on the network.
> 
> doc for pipeline param as well?

Ah, yes.

(In reply to comment #4)
> Review of attachment 218364 [details] [review]:
> 
> I'm a bit confused. how does the rygel process now build/work?

currently libserver + librenderer + rygel binary are all on-top of libcore.

with libserver + librenderer being utility libraries to ease the creation of server/renderer devices in your own code.

I'd like to have it like

              ,----------------.
              |     Rygel      |
              |________________|
                |            |
                |            |
                |            |
         ,------+------b  ...|..........
         |  libserver  |  |  librenderer
         |_____________|  L____________|
                 |               |
         ,_______|_______________|______
         |                             |
         |      libcore                |
         `-----------------------------'

In a next iteration.

(In reply to comment #5)
> (In reply to comment #3)
> > Review of attachment 218363 [details] [review] [details]:

> > ::: src/librygel-renderer/rygel-playbin-renderer.vala
> > @@ -84,1 +66,1 @@
> >       * @param title Friendly name of the new UPnP renderer on the network.
> > 
> > doc for pipeline param as well?
> 
> Ah, yes.

That's an issue with the diff, the doc is there.

Created attachment 218383 [details] [review]
New version

Created attachment 218384 [details] [review]
core,renderer: Extract base class for libraries

New version of patch

Created attachment 218385 [details] [review]
core,server,examples,doc: Add librygel-server

Zeeshan, does this look OK to you?