GNOME Bugzilla – Bug 679589
Use Action Appearance not supported for GTK 2.12 but added to widgets in Glade 3.8.2
Last modified: 2012-07-16 03:40:44 UTC
Created attachment 218298 [details] Glade file targeting GTK 2.12 with a single window and button. I am creating a glade project targeted to GTK 2.12 (debian lenny). Previously, I used glade 3.6.7 and had no problems with it. But since I upgraded to glade 3.8.2, it insists on adding the "Use Action Appearance" property to my widgets, even when I explicitly target the 2.12 GTK version. This can be verified by creating a window with a single button and then clicking the Execute button in the "Verify versions and deprecations" option. I've attached a simple glade file illustrating this. Bug summary: - What is expected to happen? Glade projects targeting GTK 2.12 should not have the "Use Action Appearance" property added to widgets. - What happens instead? Glade adds the "Use Action Appearance" to some widgets such as buttons. The resulting glade file works in GTK 2.12, but when executed, the program using the glade file displays GTK_CRITICAL errors in the terminal window. - Version used? Latest 3.8.2
Not sure if 3.8 is still maintained - it's a rather old version.
Yes, it is (somewhat) maintained as its the latest version for Gtk2. This has to be a bug when it serialize properties because use-action-appearance has the corresponding since="2.16" tag in the catalog I will take a look when I have some time, in the mean time, can I suggest some sed magic? :)
Sed magic is exactly what I am doing right now! ;) I found something that might help: the GTK2 documentation says that the default value for this property is TRUE. But I believe that the fix for the bug #582882 changed that. My glade files don't have this properly listed at all. And it seems that after the patch, when I load my glade projects, it forces the "Use Action Appearance" property to FALSE (since they're not defined), and since this is different from the default, when I save the file this key is included in the glade file.
There are two related issues First is that when we add a default in glade the value has to be saved so that it works at runtime, the other one is that we save unsupported stuff, the latter probably not to loose information. I think a good solution would be to disable use-appereance if there is no action set and skip disabled props when saving
Alright, fixed in master glade-3-8 and glade-3-12 branches What I did was * Took out default="false" for use-action-appearance, so now it should be on its gtk default (true) * set use-action-appearance insensitive if no related-action is set * only save both properties if there is a related-action set This should cover all cases including bug #582882 So let me know if it works for you thanks for reporting
Just downloaded the glade-3-8 git branch and compiled it. Now a funny thing happens: 1. Create a new project, add a window and a button, edit preferences to GTK 2.12 and click in EXECUTE: No errors! 2. Save this project and close it. Load the project again. 3. Go to preferences and click EXECUTE: errors about use-action-appearance! 4. Save the project again. Glade will complain about saving a project with errors. Save anyway. 5. Edit the glade file: use-action-appearance is not there, so the file is saved correctly besides the error warning! So the bug is fixed for new projects, but is still there for loaded projects, although saving generates a good glade file in both cases.
Traced this behaviour to the function "activatable_parse_finished" in the file "plugins/gtk+/glade-gtk.c". Is was introduced by commit 931d990a5735450c83512b9c97e32720c69c1be2. Probably to fix bug #582882, as the date and developer matches. Removing this function fixes the wrong behaviour described above.
Hmm yeah I think it is safe to remove that function as that was probably there from the old bug #582882 fix
Tell me when you commit that, so I can test again! ;)
done
Perfect now. Thank you!