After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679403 - Port WebKit version information in about dialog to WebKit2
Port WebKit version information in about dialog to WebKit2
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Backend
git master
Other Linux
: Normal normal
: ---
Assigned To: Xan Lopez
Epiphany Maintainers
Depends on:
Blocks: 678610
 
 
Reported: 2012-07-04 15:49 UTC by Carlos Garcia Campos
Modified: 2012-07-09 11:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.09 KB, patch)
2012-07-04 15:51 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2012-07-04 15:49:39 UTC 
Use WebKit2 API to get the library version
Comment 1 Carlos Garcia Campos 2012-07-04 15:51:05 UTC 
Created attachment 218023 [details] [review]
Patch
Comment 2 Xan Lopez 2012-07-09 11:13:34 UTC 
Review of attachment 218023 [details] [review]:

OK. Honestly I must say this seems like a totally pointless API change ;)
Comment 3 Carlos Garcia Campos 2012-07-09 11:19:53 UTC 
The change is consistent with GTK+, in WebKit1, the API follows webkit internal coding style instead of GNOME coding style. But the thing is that it was not on purpose, I realized WebKit1 didn't use "get" when porting ephy.