After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679341 - autocluttersink doesn't proxy "ts-offset"
autocluttersink doesn't proxy "ts-offset"
Status: RESOLVED FIXED
Product: clutter-gst
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: clutter-gst-maint
clutter-gst-maint
Depends on:
Blocks:
 
 
Reported: 2012-07-03 18:22 UTC by Bastien Nocera
Modified: 2012-09-25 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
test program (447 bytes, text/plain)
2012-07-04 09:34 UTC, Bastien Nocera 		  Details
Patch for autocluttersink that fixes the issue (3.65 KB, patch)
2012-07-04 11:51 UTC, Josep Torra Valles 		reviewed Details | Review

Description Bastien Nocera 2012-07-03 18:22:33 UTC 
It should have this property and proxy it if the child isn't instantiated yet. This breaks playbin2's av-offset.
Comment 1 Bastien Nocera 2012-07-03 18:28:21 UTC 
I've reverted the use of autocluttersink in Totem for now:
http://git.gnome.org/browse/totem/commit/?id=8106abb2f4b99f712571420869c1538f119496f0
Comment 2 Bastien Nocera 2012-07-04 09:34:06 UTC 
Created attachment 217988 [details]
test program

This test case is supposed to show the audio being 1.5 seconds early. Replace autocluttersink with cluttersink, and it will work correctly.
Comment 3 Josep Torra Valles 2012-07-04 11:51:56 UTC 
Created attachment 218007 [details] [review]
Patch for autocluttersink that fixes the issue

The provided patch proxies the ts-offset property on autocluttersink in order to fix the issue.
Comment 4 Bastien Nocera 2012-07-04 12:03:18 UTC 
Review of attachment 218007 [details] [review]:

Code looks correct and fixes the issue in my tests.
Comment 5 Damien Lespiau 2012-09-25 17:58:43 UTC 
pushed the patch master and clutter-gst-1.6 branch.