After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679321 - small tweaks to classic theme
small tweaks to classic theme
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: Chat themes
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-07-03 10:24 UTC by Frederic Peters
Modified: 2018-05-22 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot of old and new (59.76 KB, image/png)
2012-07-03 10:24 UTC, Frederic Peters
Details
Ubuntu theme (49.98 KB, image/png)
2012-07-04 14:44 UTC, Guillaume Desmottes
Details
classic theme (35.23 KB, image/png)
2012-07-04 14:44 UTC, Guillaume Desmottes
Details

Description Frederic Peters 2012-07-03 10:24:15 UTC
Created attachment 217921 [details]
screenshot of old and new

See attached screenshot (don't mind the discussion…), there are several differences between left (old theme) and right (new adium theme), mostly:

 - colours: the old theme had lighter colours, it's easy to fix (but I didn't find how they were defined before, so I just got them from the screenshot) [see below]
 - font (or is this just spacing between letters?) : not important, I'd say.
 - timestamp: the new theme  doesn't have any time indication, no idea how to fix that.


@@ -11,14 +11,15 @@ html {
 body {
   padding: 6px;
   margin: 0;
+  color: #2e3436;
 }
 
 .incoming .sender {
-  color: blue;
+  color: #4a708b;
 }
 
 .outgoing .sender {
-  color: green;
+  color: #2e8b57;
 }
Comment 1 Guillaume Desmottes 2012-07-03 11:20:50 UTC
(In reply to comment #0)
>  - colours: the old theme had lighter colours, it's easy to fix (but I didn't
> find how they were defined before, so I just got them from the screenshot) [see
> below]

Fixed in http://git.gnome.org/browse/empathy/commit/?id=e5ef72f1a021f01946245641eae2a8e031d79d90

>  - font (or is this just spacing between letters?) : not important, I'd say.

Agreed.

>  - timestamp: the new theme  doesn't have any time indication, no idea how to
> fix that.

The 'Boxes' themes implements it:

    <span class="timestamp">%time%</span>
Comment 2 Guillaume Desmottes 2012-07-04 14:43:36 UTC
Also, it would be nice to have the logs starting from the top of the view rather than the bottom. See how the Ubuntu theme displays them.
Comment 3 Guillaume Desmottes 2012-07-04 14:44:10 UTC
Created attachment 218011 [details]
Ubuntu theme
Comment 4 Guillaume Desmottes 2012-07-04 14:44:27 UTC
Created attachment 218012 [details]
classic theme
Comment 5 GNOME Infrastructure Team 2018-05-22 15:37:27 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/566.