After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679301 - tests: don't use deprecated Gtk+ symbols
tests: don't use deprecated Gtk+ symbols
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-03 04:08 UTC by Javier Jardón (IRC: jjardon)
Modified: 2012-07-03 09:04 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6

Attachments
Use G_DEFINE_TYPE instead GST_BOILERPLATE (13.52 KB, patch)
2012-07-03 04:08 UTC, Javier Jardón (IRC: jjardon) 		rejected Details | Review
tests/examples/spectrum/demo-audiotest.c: Do not use deprecated symbols (1.57 KB, patch)
2012-07-03 04:09 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
tests/examples/equalizer/demo.c: Do not use deprecated symbols (2.81 KB, patch)
2012-07-03 04:09 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
tests/icles/gdkpixbufsink-test.c: Do not use deprecated symbols (1.68 KB, patch)
2012-07-03 04:10 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2012-07-03 04:08:12 UTC 
Created attachment 217902 [details] [review]
Use G_DEFINE_TYPE instead GST_BOILERPLATE

The porting guide to 1.0 said that GST_BOILERPLATE is deprecated now

Patch following
Comment 1 Javier Jardón (IRC: jjardon) 2012-07-03 04:09:09 UTC 
Created attachment 217903 [details] [review]
tests/examples/spectrum/demo-audiotest.c: Do not use deprecated symbols
Comment 2 Javier Jardón (IRC: jjardon) 2012-07-03 04:09:56 UTC 
Created attachment 217904 [details] [review]
tests/examples/equalizer/demo.c: Do not use deprecated symbols
Comment 3 Javier Jardón (IRC: jjardon) 2012-07-03 04:10:57 UTC 
Created attachment 217905 [details] [review]
tests/icles/gdkpixbufsink-test.c: Do not use deprecated symbols
Comment 4 Tim-Philipp Müller 2012-07-03 08:01:08 UTC 
Comment on attachment 217902 [details] [review]
Use G_DEFINE_TYPE instead GST_BOILERPLATE

Sorry, but I don't see the value in committing these. The reason those elements still use GST_BOILERPLATE is that they haven't been ported yet. They should be ported in full or not at all, but just replacing random functions is not very useful. Leaving the unported code also makes it easier to cherry-pick fixes from the 0.10 branch. I will push the removal of outdated comments in the rtp elements though.
Comment 5 Tim-Philipp Müller 2012-07-03 09:03:22 UTC 
commit c6cb95f5b2d722b51a55c19d3552ca419e38f20b
Author: Javier Jardón <jjardon@gnome.org>
Date:   Tue Jul 3 12:47:58 2012 +0900

    tests: do not use deprecated gtk+ symbols
    
    https://bugzilla.gnome.org/show_bug.cgi?id=679301