After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679298 - Add an explicit way to move and copy files
Add an explicit way to move and copy files
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 480564 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-07-03 02:32 UTC by William Jon McCann
Modified: 2012-07-03 16:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add an explicit way to move and copy files (6.36 KB, patch)
2012-07-03 02:32 UTC, William Jon McCann
needs-work Details | Review
Add an explicit way to move and copy files (6.20 KB, patch)
2012-07-03 14:12 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2012-07-03 02:32:11 UTC
For an application that specializes in organizing files it is suprisingly
hard to move and copy files around in Nautilus. You can either drag and drop
or use cut/copy and paste. Drag and drop doesn't work well with touch or
for those with precision pointing problems. Cut/copy is visually disconnected
from paste and operates as a hidden mode and is indirect at best. It is better
to have an explicit way to move things around.
Comment 1 William Jon McCann 2012-07-03 02:32:13 UTC
Created attachment 217898 [details] [review]
Add an explicit way to move and copy files

Use the file chooser to select a destination directory.
Comment 2 William Jon McCann 2012-07-03 02:37:36 UTC
A few things need to be improved.

 * The file chooser needs to be consistent with nautilus
 * We need a way for the file chooser to know about the already selected items and disallow selecting them as destinations
 * We need better modal dialogs that can show a title
Comment 3 Cosimo Cecchi 2012-07-03 03:36:09 UTC
Review of attachment 217898 [details] [review]:

Looks mostly good...some comments:

::: src/nautilus-view.c
@@ +5730,3 @@
+move_copy_selection_to_location (NautilusView *view,
+				 int copy_action,
+				 char *target_uri)

Isn't this unused?

@@ +5776,3 @@
+	g_free (uri);
+
+	g_list_free_full (uris, g_free);

We shouldn't use gtk_dialog_run here, but show it and connect to its response signal.
Comment 4 William Jon McCann 2012-07-03 14:12:30 UTC
Created attachment 217935 [details] [review]
Add an explicit way to move and copy files

Use the file chooser to select a destination directory.
Comment 5 Cosimo Cecchi 2012-07-03 14:46:16 UTC
Review of attachment 217935 [details] [review]:

Thanks, looks good.
Comment 6 William Jon McCann 2012-07-03 15:18:27 UTC
Attachment 217935 [details] pushed as 8feb022 - Add an explicit way to move and copy files
Comment 7 John Stowers 2012-07-03 15:41:30 UTC
I guess this is fixed now, but IMO this doesn't quite go far enough towards my proposal.

Often I have many nautilus windows open on multiple desktops. It would be convenient to be able to move files to the locations in those windows. As I suggested previously, the move/copy to submenus could list the locations of the open nautilus windows.

Opening the file chooser to select a destination that I will then navigate to in another nautilus window seems a slower sequence of steps.
Comment 8 William Jon McCann 2012-07-03 15:46:04 UTC
I'm unaware of your proposal. Probably best to file a separate bug since it is unrelated to this.
Comment 9 John Stowers 2012-07-03 15:59:31 UTC
(In reply to comment #8)
> I'm unaware of your proposal. Probably best to file a separate bug since it is
> unrelated to this.

filed as bug 679335

(I also commented in the DDL thread, and on the related bug 676858)
Comment 10 António Fernandes 2012-07-03 16:02:53 UTC
Should bug 480564 be resolved as duplicate of this?
Comment 11 William Jon McCann 2012-07-03 16:10:20 UTC
*** Bug 480564 has been marked as a duplicate of this bug. ***