After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679292 - eject icon isn't inverted when selected
eject icon isn't inverted when selected
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-03 00:51 UTC by William Jon McCann
Modified: 2012-07-21 12:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make eject icon invert when selected (7.05 KB, patch)
2012-07-03 00:56 UTC, William Jon McCann 		committed Details | Review
prior art - os x prelight (104.64 KB, image/png)
2012-07-09 14:10 UTC, William Jon McCann 		  Details
prior art - os x selection (72.67 KB, image/png)
2012-07-09 14:11 UTC, William Jon McCann 		  Details

Description William Jon McCann 2012-07-03 00:51:52 UTC 
The eject icon in the places sidebar isn't inverted when selected.

This seems to be related to:
 * not using an icon-name data model for the cell renderer
 * the code used to special case prelighting the icon
Comment 1 William Jon McCann 2012-07-03 00:56:03 UTC 
Created attachment 217895 [details] [review]
Make eject icon invert when selected
Comment 2 William Jon McCann 2012-07-03 01:03:05 UTC 
This patch is just an example that allows invert to work. Unfortunately, it breaks prelight.
Comment 3 William Jon McCann 2012-07-09 14:10:38 UTC 
Created attachment 218341 [details]
prior art - os x prelight
Comment 4 William Jon McCann 2012-07-09 14:11:02 UTC 
Created attachment 218342 [details]
prior art - os x selection
Comment 5 Cosimo Cecchi 2012-07-11 00:43:39 UTC 
Comment on attachment 217895 [details] [review]
Make eject icon invert when selected

Pushed to master a version that uses a GIcon instead of an icon name