After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679278 - Reorganize sidebar according to mockups
Reorganize sidebar according to mockups
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-02 21:19 UTC by William Jon McCann
Modified: 2012-07-02 22:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Reorganize sidebar according to mockups (10.96 KB, patch)
2012-07-02 21:19 UTC, William Jon McCann
accepted-commit_now Details | Review
Reorganize sidebar according to mockups (11.49 KB, patch)
2012-07-02 22:50 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2012-07-02 21:19:46 UTC
The latest mockups have a few changes to the sidebar in order to prepare
for new features.
 * Change the order of sections
 * Rename Computer section to avoid confusing with the computer device
 * Use the pretty hostname for the computer device
Comment 1 William Jon McCann 2012-07-02 21:19:48 UTC
Created attachment 217874 [details] [review]
Reorganize sidebar according to mockups

 * put built in items at the top so they are stable
 * move file system item into Devices section
 * use pretty hostname instead of File System
Comment 2 Cosimo Cecchi 2012-07-02 21:30:59 UTC
Review of attachment 217874 [details] [review]:

Looks good, modulo these two trivial comments below.

::: src/nautilus-places-sidebar.c
@@ +3182,3 @@
+	} else {
+		/* Work around systemd-hostname not sending us back
+	}

I don't understand exactly what this is working around (but the control-center code seems to be doing the same...), and we're not listening for updates of this property...maybe just remove the comment?

@@ +3204,3 @@
+	sidebar->hostnamed_proxy = g_dbus_proxy_new_for_bus_finish (res, &error);
+	if (error != NULL) {
+

Maybe a warning here is a bit too much, since it's not guaranteed that the systemd service will be running; can you turn that into a debug message?
Comment 3 William Jon McCann 2012-07-02 22:50:47 UTC
Created attachment 217884 [details] [review]
Reorganize sidebar according to mockups

* put built in items at the top so they are stable
 * move file system item into Devices section
 * use pretty hostname instead of File System
Comment 4 Cosimo Cecchi 2012-07-02 22:57:33 UTC
Review of attachment 217884 [details] [review]:

Thanks, looks good!
Comment 5 William Jon McCann 2012-07-02 22:59:10 UTC
Attachment 217884 [details] pushed as fb977bd - Reorganize sidebar according to mockups