GNOME Bugzilla – Bug 679278
Reorganize sidebar according to mockups
Last modified: 2012-07-02 22:59:13 UTC
The latest mockups have a few changes to the sidebar in order to prepare for new features. * Change the order of sections * Rename Computer section to avoid confusing with the computer device * Use the pretty hostname for the computer device
Created attachment 217874 [details] [review] Reorganize sidebar according to mockups * put built in items at the top so they are stable * move file system item into Devices section * use pretty hostname instead of File System
Review of attachment 217874 [details] [review]: Looks good, modulo these two trivial comments below. ::: src/nautilus-places-sidebar.c @@ +3182,3 @@ + } else { + /* Work around systemd-hostname not sending us back + } I don't understand exactly what this is working around (but the control-center code seems to be doing the same...), and we're not listening for updates of this property...maybe just remove the comment? @@ +3204,3 @@ + sidebar->hostnamed_proxy = g_dbus_proxy_new_for_bus_finish (res, &error); + if (error != NULL) { + Maybe a warning here is a bit too much, since it's not guaranteed that the systemd service will be running; can you turn that into a debug message?
Created attachment 217884 [details] [review] Reorganize sidebar according to mockups * put built in items at the top so they are stable * move file system item into Devices section * use pretty hostname instead of File System
Review of attachment 217884 [details] [review]: Thanks, looks good!
Attachment 217884 [details] pushed as fb977bd - Reorganize sidebar according to mockups