After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679264 - missing GObjectIntrospection tags in EvDocument
missing GObjectIntrospection tags in EvDocument
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-02 15:30 UTC by Ferdinand Schwenk
Modified: 2012-07-02 16:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
untestet patch with docstrings and GObjectIntrospection tags (1.31 KB, patch)
2012-07-02 15:34 UTC, Ferdinand Schwenk 		committed Details | Review

Description Ferdinand Schwenk 2012-07-02 15:30:23 UTC 
function get_page_size is not correctly taged and get_page was not found in python using gi.repository.
Comment 1 Ferdinand Schwenk 2012-07-02 15:34:08 UTC 
Created attachment 217848 [details] [review]
untestet patch with docstrings and GObjectIntrospection tags
Comment 2 Carlos Garcia Campos 2012-07-02 16:06:34 UTC 
Review of attachment 217848 [details] [review]:

Fixed the issues mentioned and pushed to git master. Thanks!

::: libdocument/ev-document.c
@@ +443,3 @@
+ * @page_index: index of page
+ *
+ * Returns: (transfer: full): Newly created #EvPage for the given index.

This should be (transfer full)

@@ +598,3 @@
+ * @document: a #EvDocument
+ * @page_index: index of page
+ * @width: (allow-none)(out): return location for the width of the page, or %NULL

I'm not sure it's needed by I prefer to leave a space between annotations.
Comment 3 Ferdinand Schwenk 2012-07-02 16:25:12 UTC 
Thanks for the quick response!