Created attachment 217781 [details] [review]
networkmanager-pptp patch

As described in https://bugzilla.gnome.org/show_bug.cgi?id=679212 , gnome-shell has trouble finding the nm-pptp-auth-dialog if the pptp networkmanager plugin is installed in a libexecdir different from the one used by gnome-shell. This is the case for the Arch Linux distribution. From ~/.xsession-errors:

      JS LOG: Error 'VPN plugin at /usr/lib/gnome-shell/nm-pptp-auth-dialog is
not executable' while processing VPN keyfile '/etc/NetworkManager/VPN/nm-pptp-service.name'

A suggested fix is to configure an absolute path to nm-pptp-auth-diag in the VPN keyfile /etc/NetworkManager/VPN/nm-vpnc-service.name. See patch below.

Please note that setups which use the same libexecdir for both gnome-shell and networkmanager-pptp probably do not have this issue. And this patch will _break_ such setups, because gnome-shell unconditionally prepends its own libexecdir even to absolute paths. A patch to make gnome-shell accept absolute paths has also been proposed. This patch needs to be applied before patching networkmanager-pptp.

Other VPN plugins need to be patched as well. Should I provide those as well? I don't have any other VPNs setup to test right now, but the change should be analogous:

      JS LOG: Error 'VPN plugin at
/usr/lib/gnome-shell/nm-openconnect-auth-dialog is not executable' while
processing VPN keyfile '/etc/NetworkManager/VPN/nm-openconnect-service.name'
      JS LOG: Error 'VPN plugin at /usr/lib/gnome-shell/nm-vpnc-auth-dialog is
not executable' while processing VPN keyfile '/etc/NetworkManager/VPN/nm-vpnc-service.name'

* Arch Linux package versions

gnome-shell 3.4.1-3
networkmanager 0.9.4.0-6
networkmanager-pptp 0.9.4.0-1