After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679177 - housekeeping: Don't leak notification objects
housekeeping: Don't leak notification objects
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: housekeeping
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-30 04:02 UTC by Matthias Clasen
Modified: 2012-07-03 09:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.42 KB, patch)
2012-06-30 04:02 UTC, Matthias Clasen 		reviewed Details | Review
housekeeping: Don't leak notification objects (1.46 KB, patch)
2012-07-02 23:19 UTC, Matthias Clasen 		none Details | Review
updated patch (1.47 KB, patch)
2012-07-02 23:20 UTC, Matthias Clasen 		none Details | Review
housekeeping: Don't leak notification objects (820 bytes, patch)
2012-07-03 09:14 UTC, Bastien Nocera 		committed Details | Review

Description Matthias Clasen 2012-06-30 04:02:42 UTC 
Created attachment 217683 [details] [review]
patch

NotifyNotification objects have to be freed using g_object_unref
Comment 1 Bastien Nocera 2012-07-02 09:09:29 UTC 
Review of attachment 217683 [details] [review]:

::: plugins/housekeeping/gsd-disk-space.c
@@ -359,3 @@
-                g_signal_connect (notification,
-                                  "closed",
-                                  G_CALLBACK (on_notification_closed),

The indentation changes in this hunk aren't needed.
Comment 2 Matthias Clasen 2012-07-02 23:19:19 UTC 
Created attachment 217887 [details] [review]
housekeeping: Don't leak notification objects
Comment 3 Matthias Clasen 2012-07-02 23:20:40 UTC 
Created attachment 217888 [details] [review]
updated patch
Comment 4 Bastien Nocera 2012-07-03 09:07:45 UTC 
Unless I'm mistaken, all 3 patches are the exact same.
Comment 5 Bastien Nocera 2012-07-03 09:14:30 UTC 
Created attachment 217913 [details] [review]
housekeeping: Don't leak notification objects
Comment 6 Bastien Nocera 2012-07-03 09:18:32 UTC 
Attachment 217913 [details] pushed as 02ad04b - housekeeping: Don't leak notification objects