GNOME Bugzilla – Bug 679130
NetworkManager-pptp-0.9.5.95: build failure due to deprecated symbols
Last modified: 2012-11-02 16:53:02 UTC
Please when using -Werror, ensure that these deprecations are not treated as errors. At the moment I cannot build NetworkManager-pptp-0.9.5.95. /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I/usr/include/NetworkManager -I/usr/i gcc -DHAVE_CONFIG_H -I. -I.. -I.. -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/Netwo libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I/usr/include/NetworkManager -I/usr/include/glib-2.0 -I/usr/lib64/ /bin/sh ../libtool --tag=CC --mode=link gcc -Wall -std=gnu89 -O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FOR libtool: link: gcc -shared -Wl,--as-needed .libs/nm_pptp_pppd_plugin_la-nm-pptp-pppd-plugin.o -Wl,--as-needed -Wl,-z libtool: link: ( cd ".libs" && rm -f "nm-pptp-pppd-plugin.la" && ln -s "../nm-pptp-pppd-plugin.la" "nm-pptp-pppd-plugin. /bin/sh ../libtool --tag=CC --mode=link gcc -Wall -std=gnu89 -O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FOR libtool: link: gcc -Wall -std=gnu89 -O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protec make[3]: Leaving directory `/home/iurt/rpm/BUILD/NetworkManager-pptp-0.9.5.95/src' make[2]: Leaving directory `/home/iurt/rpm/BUILD/NetworkManager-pptp-0.9.5.95/src' Making all in auth-dialog make[2]: Entering directory `/home/iurt/rpm/BUILD/NetworkManager-pptp-0.9.5.95/auth-dialog' gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I/usr/include/NetworkManager -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I/usr/include/NetworkManager -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I vpn-password-dialog.c: In function 'add_row': vpn-password-dialog.c:127:2: error: 'gtk_table_attach_defaults' is deprecated (declared at /usr/include/gtk-3.0/gtk/depr vpn-password-dialog.c:128:2: error: 'gtk_table_attach_defaults' is deprecated (declared at /usr/include/gtk-3.0/gtk/depr vpn-password-dialog.c: In function 'add_table_rows': vpn-password-dialog.c:157:2: error: 'gtk_table_attach_defaults' is deprecated (declared at /usr/include/gtk-3.0/gtk/depr vpn-password-dialog.c: In function 'vpn_password_dialog_new': vpn-password-dialog.c:231:2: error: 'gtk_table_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkta vpn-password-dialog.c:232:2: error: 'gtk_table_set_col_spacings' is deprecated (declared at /usr/include/gtk-3.0/gtk/dep vpn-password-dialog.c:233:2: error: 'gtk_table_set_row_spacings' is deprecated (declared at /usr/include/gtk-3.0/gtk/dep cc1: all warnings being treated as errors make[2]: *** [nm_pptp_auth_dialog-vpn-password-dialog.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[2]: Leaving directory `/home/iurt/rpm/BUILD/NetworkManager-pptp-0.9.5.95/auth-dialog' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/iurt/rpm/BUILD/NetworkManager-pptp-0.9.5.95'
Same problem with 0.9.6. Werror can be disabled like this: ./configure --enable-more-warnings=no, but I wonder how Arch managed to build this, since the package is not using that option.
Created attachment 227887 [details] [review] build: set GDK_VERSION_MIN_REQUIRED, to avoid deprecation warnings ===== This should also fix the build, even with -Werror still set. Can you test that?
Fixes the build for me. Some other issues currently prevent me from verifying that actually connecting to a VPN still works. But if I understand correctly, this should not change anything besides disabling the deprecation warnings?
right
Attachment 227887 [details] pushed as a0eca5e - build: set GDK_VERSION_MIN_REQUIRED, to avoid deprecation warnings
Thanks. I also managed to successfully test this in action now.