GNOME Bugzilla – Bug 6791
gtk file dialog deletes filename after selecting other directory
Last modified: 2011-02-04 16:09:06 UTC
Package: gtk+ Severity: wishlist Version: 1.2.6 >Synopsis: gtk file dialog deletes filename after selecting other directory >Class: sw-bug Distribution: Red Hat Linux release 6.1 (Cartman) System: Linux 2.2.12-20 i686 unknown C library: glibc-2.1.2-11 C compiler: egcs-2.91.66 glib: 1.2.6 GTK+: 1.2.6 ORBit: ORBit 0.5.0 gnome-libs: gnome-libs 1.0.55 gnome-core: gnome-core 1.1.5 >Description: When you type a filename in a GTK (or GNOME?) FileDialog, the name is gone after you select another directory. This is especially annoying in Mozilla, when you want to download a file, and want to change the directory, but not the filename. Also, when you have a file open in, say gEdit, and want to save it under another name, it would be nice if the original filename is presented and selected, so you can just start typing another filename, or browse to another directory to save it there under the same filename. This was also a bug (feature) in Motif, and a pain in Netscape!! I hope I made my point clear enough. >How-To-Repeat: 1) start Mozilla, and go to the FTP site of your preference (ftp.gnome.org?). Click on a file you want to download. A GTK dialog opens with the correct filename filled in. Click on '..' in the directory pane to go one directory up. The filename is gone. or 2) open a textfile in gEdit. make some changes. Click 'save as' in the menu. A file selector dialog opens with no name filled in... (having the original name would be handy - especially if the name would remain if you select another directory) ------- Bug moved to this database by debbugs-export@bugzilla.gnome.org 2001-01-27 14:47 ------- This bug was previously known as bug 6791 at http://bugs.gnome.org/ http://bugs.gnome.org/show_bug.cgi?id=6791 Originally filed under the gtk+ product and general component. The original reporter (jos.dehaes@bigfoot.com) of this bug does not have an account here. Reassigning to the exporter, debbugs-export@bugzilla.gnome.org. Reassigning to the default owner of the component, gtk-bugs@gtk.org.
Put all GTK 1.3.x bugs on 2.0.0 milestone
*** Bug 56962 has been marked as a duplicate of this bug. ***
Seee comments in 56962 for rational for assigment to 'future'
*** Bug 59380 has been marked as a duplicate of this bug. ***
*** Bug 60166 has been marked as a duplicate of this bug. ***
60166 includes a simple patch that fixes the most obvious symptoms. Needs to be looked at more closely, but may be worth applying for 2.0.
*** Bug 62256 has been marked as a duplicate of this bug. ***
*** Bug 62910 has been marked as a duplicate of this bug. ***
*** Bug 63687 has been marked as a duplicate of this bug. ***
*** Bug 56261 has been marked as a duplicate of this bug. ***
*** Bug 63733 has been marked as a duplicate of this bug. ***
Created attachment 6114 [details] [review] patch against gtk+2
Just attached a patch for this bug against gtk+2, ChangeLog: Thu Nov 29 22:33:46 2001 Kristian Rietveld <kristian@planet.nl> * gtk/gtkfilesel.c: add a OLD_FILENAME_KEY, (gtk_file_selection_dir_button): remove data if it exists and this isn't a second click, add data if this is the first click (gtk_file_selection_populate): if this isn't a population triggered by completion and there's an old filename, set the saved filename as text in the entry
*** Bug 67083 has been marked as a duplicate of this bug. ***
I think the patch is working a little harder than it needs to be. The observation I'd make is that there is absolutely no reason why clicking on the dir list should ever affect the text in the entry. Wed Jan 16 20:28:38 2002 Owen Taylor <otaylor@redhat.com> * gtk/gtkfilesel.c: Fix "deleting" filename by adding another boolean parameter to file_selection_populate() - whether to clear the entry. Also, never fill in the entry when the user clicks on something in the directory list. (#6791, Reported by Jos Dehaes and many, many, many others.) Diff attached for ease in backporting for 1.2.11.
Created attachment 6421 [details] [review] Patch as applied to HEAD
*** Bug 70432 has been marked as a duplicate of this bug. ***
*** Bug 70656 has been marked as a duplicate of this bug. ***
*** Bug 71876 has been marked as a duplicate of this bug. ***
*** Bug 71972 has been marked as a duplicate of this bug. ***
*** Bug 78820 has been marked as a duplicate of this bug. ***
*** Bug 79319 has been marked as a duplicate of this bug. ***
*** Bug 79572 has been marked as a duplicate of this bug. ***
*** Bug 79606 has been marked as a duplicate of this bug. ***
Created attachment 7890 [details] [review] Patch from current Rawhide GTK+-1.2 RPM with backport of HEAD changes
*** Bug 80090 has been marked as a duplicate of this bug. ***
*** Bug 80304 has been marked as a duplicate of this bug. ***
*** Bug 80445 has been marked as a duplicate of this bug. ***
*** Bug 81486 has been marked as a duplicate of this bug. ***
*** Bug 84249 has been marked as a duplicate of this bug. ***
*** Bug 84310 has been marked as a duplicate of this bug. ***
*** Bug 85311 has been marked as a duplicate of this bug. ***
*** Bug 87151 has been marked as a duplicate of this bug. ***
*** Bug 93732 has been marked as a duplicate of this bug. ***
*** Bug 81901 has been marked as a duplicate of this bug. ***
Should we leave this open just for the 1.2.11 milestone? Is anyone ever going to make such a release, or can we just mark it with the "GNOME 1.x" resolution?
Setting the priority to "Low" for all bugs related to GtkFileSelection. This has been deprecated in favor of GtkFileChooser.
So, now that GtkFileSelection is going away, this can be resolved, correct?
No 1.2.11 is planned, so closing all 1.2.11 specific bugs.
Owen, did you mean to close this bug?
*Really* close all 1.2.11 bugs, instead of just adding a comment...