After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679090 - Introspection and Vala fixes
Introspection and Vala fixes
Status: RESOLVED FIXED
Product: libsecret
Classification: Other
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libsecret maintainer(s)
libsecret maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-06-28 21:56 UTC by Evan Nemerson
Modified: 2012-07-10 20:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vala: update metadata to reflect changes made by 89550876 (1.04 KB, patch)
2012-06-28 21:57 UTC, Evan Nemerson 		committed Details | Review
introspection: add several missing element-type annotations (4.72 KB, patch)
2012-06-28 21:58 UTC, Evan Nemerson 		accepted-commit_now Details | Review
introspection: add several missing element-type annotations (3.94 KB, patch)
2012-07-10 20:07 UTC, Evan Nemerson 		committed Details | Review

Description Evan Nemerson 2012-06-28 21:56:51 UTC 
Various items are missing type arguments, and the changes from 89550876 are causing some warnings from vapigen.
Comment 1 Evan Nemerson 2012-06-28 21:57:45 UTC 
Created attachment 217566 [details] [review]
vala: update metadata to reflect changes made by 89550876
Comment 2 Evan Nemerson 2012-06-28 21:58:29 UTC 
Created attachment 217567 [details] [review]
introspection: add several missing element-type annotations
Comment 3 Stef Walter 2012-06-29 05:36:09 UTC 
Review of attachment 217567 [details] [review]:

Looks good.
Comment 4 Stef Walter 2012-06-29 05:36:16 UTC 
Review of attachment 217566 [details] [review]:

Thanks looks good.
Comment 5 Evan Nemerson 2012-07-10 20:07:40 UTC 
Created attachment 218467 [details] [review]
introspection: add several missing element-type annotations

Old version no longer applies :(

I'll push right after it's reviewed this time.