GNOME Bugzilla – Bug 679067
Add new functions to pad buttons mapping
Last modified: 2012-08-21 16:09:43 UTC
Bug 679062 and bug 668908 implements new functionality that can be assigned to the buttons of the pad, this bug is to allow the user to select these alternate functions in the button mapping UI.
Created attachment 217531 [details] [review] Proposed patch This patch adds a new column to the existing treeview with a combo to select the type of actions assigned to each button as seen in the mockups on [1] [1] https://live.gnome.org/Design/SystemSettings/Tablet#Mockups
Created attachment 217925 [details] [review] Updated patch Updated patch, do not show the "Switch monitor" function for screen tablets.
Created attachment 221987 [details] [review] Updated patch without the OSD/HELP window function This patch adds the "Switch monitor" function to possible actions on pad buttons, for the UI part of bug 668908 (the HELP/OSD window part is left out for now)
Created attachment 221988 [details] Screenshot of the UI with the proposed patch
Review of attachment 221987 [details] [review]: ::: panels/wacom/cc-wacom-page.c @@ +588,3 @@ +get_action_name (GsdWacomActionType action_type) +{ + gint i; That would work, no? return _(action_table[action_type].action_name); @@ +744,3 @@ + priv->action_store = gtk_list_store_new (ACTION_N_COLUMNS, G_TYPE_STRING, G_TYPE_INT); + gtk_list_store_append (priv->action_store, &iter); + gtk_list_store_set (priv->action_store, &iter, Can't you filll it with a loop on the action_table array?
Created attachment 222005 [details] [review] Updated patch Updated patch after review from comment #5, also use the define for all monitors added in the patch for bug 668908 for clarity.
Pushed to git