After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679059 - pkgconfig: Move libxml-2.0 dependency to Requires.private
pkgconfig: Move libxml-2.0 dependency to Requires.private
Status: RESOLVED FIXED
Product: gdl
Classification: Other
Component: general
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: Anjuta maintainers
Anjuta maintainers
Depends on:
Blocks:
 
 
Reported: 2012-06-28 12:35 UTC by Kalev Lember
Modified: 2012-07-01 09:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pkgconfig: Move libxml-2.0 dependency to Requires.private (949 bytes, patch)
2012-06-28 12:36 UTC, Kalev Lember 		accepted-commit_now Details | Review

Description Kalev Lember 2012-06-28 12:35:18 UTC 
Fedora's libgdl package carries a downstream patch to remove libxml-2.0 from gdl-3.0.pc. I don't really know the history why the patch was added, but in any case I agree that this dependency belongs to Requires.private.

http://pkgs.fedoraproject.org/gitweb/?p=libgdl.git;a=blob;f=libgdl-2.91.4-pkgconfig.patch;h=b5710fc342556ed655bc89ca9b0e20a59a15a5fc;hb=HEAD

Attaching a patch that moves libxml-2.0 from Requires to Requires.private.
Comment 1 Kalev Lember 2012-06-28 12:36:38 UTC 
Created attachment 217518 [details] [review]
pkgconfig: Move libxml-2.0 dependency to Requires.private

Requires should only list dependencies that are needed when linking
against the shared library. Any other dependency that's only used
internally in the library and not exposed in the interface should go to
Requires.private.
Comment 2 Sébastien Granjoux 2012-07-01 09:16:53 UTC 
Review of attachment 217518 [details] [review]:

Thank you for your patch, I have just committed it.