After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678947 - Make it possible to ignore GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED
Make it possible to ignore GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
3.5.x
Other Linux
: Normal enhancement
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-27 08:54 UTC by Rico Tzschichholz
Modified: 2012-10-04 20:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
prefs: add ignore-request-hide-titlebar setting (4.55 KB, patch)
2012-06-27 08:54 UTC, Rico Tzschichholz 		none Details | Review
prefs: add ignore-request-hide-titlebar setting (4.55 KB, patch)
2012-06-27 08:57 UTC, Rico Tzschichholz 		needs-work Details | Review
prefs: add get_/set_ignore_request_hide_titlebar () (2.59 KB, patch)
2012-06-27 15:44 UTC, Rico Tzschichholz 		none Details | Review
prefs: add get_/set_ignore_request_hide_titlebar () (2.59 KB, patch)
2012-06-27 15:49 UTC, Rico Tzschichholz 		accepted-commit_now Details | Review

Description Rico Tzschichholz 2012-06-27 08:54:55 UTC 
Created attachment 217351 [details] [review]
prefs: add ignore-request-hide-titlebar setting

This adds a "ignore-request-hide-titlebar" gsettings key which enables the possibility to prevent hiding the titlebar of applications even if they requested so.

Implementing plugins based on mutter which don't want to or aren't ready to deal with GTK_IGNORE_REQUEST_HIDE_TITLEBAR are currently forced to follow the hard-coded behavior here.
Comment 1 Rico Tzschichholz 2012-06-27 08:57:56 UTC 
Created attachment 217352 [details] [review]
prefs: add ignore-request-hide-titlebar setting
Comment 2 Colin Walters 2012-06-27 14:47:42 UTC 
Who would use this and why?
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-06-27 15:23:01 UTC 
You talk in the commit message about plugins based on mutter - I'm not sure a gsetting is the best approach for that. Do you want a user setting, or do you want a plugin setting?
Comment 4 Florian Müllner 2012-06-27 15:26:02 UTC 
As far as I know it is for the elementary folks who work on a WM based on mutter, and yes, an API call sounds like the better choice here ...
Comment 5 Rico Tzschichholz 2012-06-27 15:27:35 UTC 
Yeah an internal plugin setting would work too. Exposing an user-visible setting isnt really needed.
Comment 6 Florian Müllner 2012-06-27 15:30:41 UTC 
Comment on attachment 217352 [details] [review]
prefs: add ignore-request-hide-titlebar setting

(In reply to comment #5)
> Yeah an internal plugin setting would work too. Exposing an user-visible
> setting isnt really needed.

Marking needs-work then to get it off the review list
Comment 7 Rico Tzschichholz 2012-06-27 15:44:42 UTC 
Created attachment 217416 [details] [review]
prefs: add get_/set_ignore_request_hide_titlebar ()

Made it an internal setting only.
Comment 8 Rico Tzschichholz 2012-06-27 15:49:13 UTC 
Created attachment 217417 [details] [review]
prefs: add get_/set_ignore_request_hide_titlebar ()
Comment 9 Jasper St. Pierre (not reading bugmail) 2012-07-01 17:16:02 UTC 
Review of attachment 217417 [details] [review]:

Sure, this works for me.
Comment 10 Jasper St. Pierre (not reading bugmail) 2012-10-04 19:14:00 UTC 
Rico, were you going to push this?
Comment 11 Jasper St. Pierre (not reading bugmail) 2012-10-04 20:50:31 UTC 
Ah, apparently this was pushed a while back.