After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678909 - build: Don't write tld_data.inc to srcdir which may not be writable
build: Don't write tld_data.inc to srcdir which may not be writable
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
unspecified
Other All
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2012-06-26 17:42 UTC by Colin Walters
Modified: 2012-06-26 20:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Don't write tld_data.inc to srcdir which may not be writable (865 bytes, patch)
2012-06-26 17:42 UTC, Colin Walters 		committed Details | Review
tld-parser: Rewrite in Python (5.31 KB, patch)
2012-06-26 17:46 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2012-06-26 17:42:16 UTC 
Generated data should go in the builddir.
Comment 1 Colin Walters 2012-06-26 17:42:18 UTC 
Created attachment 217313 [details] [review]
build: Don't write tld_data.inc to srcdir which may not be writable
Comment 2 Colin Walters 2012-06-26 17:46:05 UTC 
Created attachment 217314 [details] [review]
tld-parser: Rewrite in Python

This fixes 'make distcheck' issues.

It also helps for cross-compilation, because automake doesn't sanely
support building temporary tools for the host, as far as I know.
Comment 3 Dan Winship 2012-06-26 18:31:38 UTC 
Comment on attachment 217313 [details] [review]
build: Don't write tld_data.inc to srcdir which may not be writable

right
Comment 4 Dan Winship 2012-06-26 18:34:27 UTC 
Comment on attachment 217314 [details] [review]
tld-parser: Rewrite in Python

looks good, assuming it distchecks after this

> It also helps for cross-compilation, because automake doesn't sanely
> support building temporary tools for the host, as far as I know.

It does, as long as you don't need to both run and install it. But python is better anyway.
Comment 5 Colin Walters 2012-06-26 20:49:17 UTC 
Attachment 217313 [details] pushed as cb13cab - build: Don't write tld_data.inc to srcdir which may not be writable
Attachment 217314 [details] pushed as 29345a6 - tld-parser: Rewrite in Python