After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678888 - Set post install config soon after starting domain
Set post install config soon after starting domain
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-06-26 14:49 UTC by Zeeshan Ali
Modified: 2016-03-31 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Set post install config soon after starting domain (2.30 KB, patch)
2012-06-26 14:50 UTC, Zeeshan Ali
committed Details | Review

Description Zeeshan Ali 2012-06-26 14:49:59 UTC
There is no need to wait for domain to shutdown first. Since our VMs are shared with all apps using libvirt, its a very real scenerio that first post-install reboot happens while Boxes is not runnnig: User launches the saved (in-installation) domain from another (libvirt-based) app. This patch fixes that.

A small bonus of doing this is that it also makes the issue of libvirt events not getting in[1] much less severe (i-e Fedora installer wont keep installing over and over again).

[1] https://bugzilla.redhat.com/show_bug.cgi?id=819617
Comment 1 Zeeshan Ali 2012-06-26 14:50:01 UTC
Created attachment 217298 [details] [review]
Set post install config soon after starting domain

There is no need to wait for domain to shutdown first. Since our VMs are
shared with all apps using libvirt, its a very real scenerio that first
post-install reboot happens while Boxes is not runnnig: User launches the
saved (in-installation) domain from another (libvirt-based) app. This
patch fixes that.

A small bonus of doing this is that it also makes the issue of libvirt
events not getting in[1] much less severe (i-e Fedora installer wont keep
installing over and over again).

[1] https://bugzilla.redhat.com/show_bug.cgi?id=819617
Comment 2 Marc-Andre Lureau 2012-06-26 14:54:16 UTC
Review of attachment 217298 [details] [review]:

ack