GNOME Bugzilla – Bug 678881
Test failures in /socket/timed_wait in some cases: (99240 >= 100000)
Last modified: 2012-06-26 16:35:28 UTC
Hello, The /socket/timed_wait test does this assertion: g_socket_condition_timed_wait (client, G_IO_IN, 100000 /* 100 ms */, NULL, &error); [...] poll_duration = g_get_monotonic_time () - start_time; g_assert_cmpint (poll_duration, >=,100000); g_assert_cmpint (poll_duration, <, 110000); However, in our builders this often fails with something like: ERROR:/build/buildd/glib2.0-2.33.2/./gio/tests/socket.c:619:test_timed_wait: assertion failed (poll_duration > = 100000): (99240 >= 100000) FAIL The test allows some jitter in the upwards direction. Would it be appropriate to also allow some jitter in the other direction, or is that an actual bug here? Our builders run with some slightly older kernels, I don't get this bug on my workstation.
Created attachment 217294 [details] [review] Allow some negative timespan delta on the socket timeout test I applied this patch to the Debian package for now to work around this. This is one of the very few tests that fail during build, and we now want our package build to fail if any of the tests fails. This will allow us to spot regressions on particular architectures a lot easier. Thanks!
Comment on attachment 217294 [details] [review] Allow some negative timespan delta on the socket timeout test it looks like poll() allows for some slack in the timeout, so I guess this is good
Thanks, committed with a slightly more verbose changelog.