After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678849 - wrong wizard step shown with live cd
wrong wizard step shown with live cd
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.5.x (unsupported)
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-06-26 09:37 UTC by Christophe Fergeau
Modified: 2016-03-31 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
wizard: Simplify setup page skipping logic a bit (1.78 KB, patch)
2012-07-04 20:39 UTC, Zeeshan Ali
committed Details | Review

Description Christophe Fergeau 2012-06-26 09:37:02 UTC
Start boxes, pick a f17 live CD from the file chooser, the summary page is displayed. Click "previous"
-> the configuration page is shown
Expected result: the "selection" page is shown.
Comment 1 Zeeshan Ali 2012-07-04 20:39:09 UTC
Created attachment 218051 [details] [review]
wizard: Simplify setup page skipping logic a bit

This also fixes the regression of 'SETUP' not being skipped for live
medias when going backwords in wizard.
Comment 2 Zeeshan Ali 2012-07-04 20:40:39 UTC
To test this patch against non-unattended case (ubuntu for example), you'd need the last patch from bug#678894.
Comment 3 Zeeshan Ali 2012-07-10 20:00:32 UTC
ping
Comment 4 Christophe Fergeau 2012-07-11 06:50:13 UTC
The wizard state machinery is very cryptic to me, it would be better if Marc André could review this.
Comment 5 Marc-Andre Lureau 2012-07-11 16:26:38 UTC
Review of attachment 218051 [details] [review]:

looks good, ack
Comment 6 Zeeshan Ali 2012-07-11 17:31:34 UTC
Attachment 218051 [details] pushed as 93afdd0 - wizard: Simplify setup page skipping logic a bit