After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678829 - Bloatpad example application has "parse" action instead of "paste"
Bloatpad example application has "parse" action instead of "paste"
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkApplication
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-06-26 03:28 UTC by Micah Carrick
Modified: 2012-07-11 11:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Renames the "parse" action to "paste" (1.70 KB, patch)
2012-06-26 03:28 UTC, Micah Carrick 		accepted-commit_now Details | Review
Fix typo replacing action "Parse" with "Paste" (1.51 KB, patch)
2012-07-11 11:25 UTC, Matthias Clasen 		committed Details | Review

Description Micah Carrick 2012-06-26 03:28:50 UTC 
Created attachment 217260 [details] [review]
Renames the "parse" action to "paste"

The Bloatpad example application for GtkApplication specifies an action for "Parse" in the XML for window actions but the code seems to be looking for "Paste".
Comment 1 Allison Karlitskaya (desrt) 2012-06-26 03:42:47 UTC 
Review of attachment 217260 [details] [review]:

Other than the obvious mistake this is correct.

Thanks.

::: examples/bloatpad.c
@@ +156,3 @@
   gtk_grid_attach (GTK_GRID (grid), scrolled, 0, 1, 1, 1);
 
+  if (file != NULL)gtk_application_add_accelerator()

oops?
Comment 2 Micah Carrick 2012-06-26 03:58:54 UTC 
Oops, sorry, don't know how that got in there. Might have been a bit CTRL+V happy.
Comment 3 Matthias Clasen 2012-07-11 11:25:38 UTC 
The following fix has been pushed:
0ddb502 Fix typo replacing action "Parse" with "Paste"
Comment 4 Matthias Clasen 2012-07-11 11:25:41 UTC 
Created attachment 218536 [details] [review]
Fix typo replacing action "Parse" with "Paste"

The builder XML description has an action for "win.parse" but the
application is looking for "win.paste". Rename the label to
"_Paste" and the action to "win.paste" in the window action XML.