GNOME Bugzilla – Bug 678816
remoteSearch: Allow to reference .desktop file for Title/Icon
Last modified: 2012-06-25 21:02:05 UTC
See patch.
Created attachment 217240 [details] [review] remoteSearch: Use GIcon instead of icon name Currently we pass an icon name for the 'icon' parameter of the RemoteSearchProvider constructor. In hindsight, using a GIcon instead will give us a bit more flexibility, so change it.
Created attachment 217241 [details] [review] remoteSearch: Parse 'DesktopId' field in key file We strongly expect applications to use the same values for the 'Title'/'Icon' fields in their search provider .ini file as the 'Name'/'Icon' fields in their .desktop file. Rather than requiring applications to duplicate those fields, allow them to specify a 'DesktopId' field instead to point to the corresponding .desktop file, which makes it possible to ship search provider files without translatable strings (which is nice given that merging translations into search provider files lacks a standard rule).
Review of attachment 217240 [details] [review]: Sure.
Review of attachment 217241 [details] [review]: LGTM.
Attachment 217240 [details] pushed as 4d77eb9 - remoteSearch: Use GIcon instead of icon name Attachment 217241 [details] pushed as bc91b7d - remoteSearch: Parse 'DesktopId' field in key file