After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678769 - Introductory banner too wide
Introductory banner too wide
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: installer
3.4.x (unsupported)
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-06-25 09:09 UTC by Jakub Steiner
Modified: 2016-03-31 13:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
text lines too wide, unpleasant proportions/layout. (275.84 KB, image/png)
2012-06-25 09:11 UTC, Jakub Steiner
  Details
small res - no white space on the right hand side (260.55 KB, image/png)
2012-06-25 09:11 UTC, Jakub Steiner
  Details
appropriate layout on the next page. (232.00 KB, image/png)
2012-06-25 09:12 UTC, Jakub Steiner
  Details
Fix layout of initial wizard page (2.97 KB, patch)
2012-06-27 09:59 UTC, Alexander Larsson
committed Details | Review

Description Jakub Steiner 2012-06-25 09:09:27 UTC
I recommend having lower max-width for the introductory graphic + text. It is extremely wide now and doesn't look good on _any_ resolution. Lower resolution/screen size lacks white space on the right hand side, and high resolution screens make the super long lines of text hard to read and visually unbalanced.

The recommend using the same width as the menu widget on the next page.
Comment 1 Jakub Steiner 2012-06-25 09:11:01 UTC
Created attachment 217180 [details]
text lines too wide, unpleasant proportions/layout.
Comment 2 Jakub Steiner 2012-06-25 09:11:34 UTC
Created attachment 217181 [details]
small res - no white space on the right hand side
Comment 3 Jakub Steiner 2012-06-25 09:12:30 UTC
Created attachment 217182 [details]
appropriate layout on the next page.
Comment 4 Alexander Larsson 2012-06-27 09:59:29 UTC
Created attachment 217378 [details] [review]
Fix layout of initial wizard page

The page had no max width, making the label become very
wide (not wrapping) when the window was wide. Also, the
margins were not consisten.

The fix works by setting the minimal size and the margin
on the notebook itself, and properly centering the first
notebook page. We also set a max width on the label.
Comment 5 Christophe Fergeau 2012-06-27 10:12:52 UTC
Review of attachment 217378 [details] [review]:

Looks good apart from a small nit.

::: src/wizard.vala
@@ +420,3 @@
         // Work around clutter size allocation issue (bz#677260)
         label.width_chars = 30;
+        label.max_width_chars = 30;

30 looks a bit cramped here, and makes the text + image smaller than the iso chooser on the next page. 40 looks better imo (at least on my setup).
Comment 6 Alexander Larsson 2012-06-28 07:50:55 UTC
Attachment 217378 [details] pushed as d36ca03 - Fix layout of initial wizard page
Comment 7 Alexander Larsson 2012-06-28 07:51:29 UTC
I agree, pushed with that change.