After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678767 - isomp4/qtdemux: Allow duration queries to be forwarded upstream
isomp4/qtdemux: Allow duration queries to be forwarded upstream
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.31
Other All
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-06-25 09:04 UTC by David Corvoysier
Modified: 2012-06-28 12:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (921 bytes, patch)
2012-06-25 09:04 UTC, David Corvoysier 		needs-work Details | Review
Updated patch with upstream query performed first (1.37 KB, patch)
2012-06-28 12:18 UTC, David Corvoysier 		committed Details | Review

Description David Corvoysier 2012-06-25 09:04:27 UTC 
Created attachment 217175 [details] [review]
Proposed patch

The qtdemux currently drops duration queries coming from downstream if it cannot handle them, whereas according to §23.3 of the plugin writer's guide it shoudn't.
Comment 1 Sebastian Dröge (slomo) 2012-06-25 09:37:35 UTC 
Review of attachment 217175 [details] [review]:

It should *first* try to query upstream (for TIME format only), and only if upstream fails fall back to its own duration handling.
Comment 2 David Corvoysier 2012-06-28 12:18:58 UTC 
Created attachment 217517 [details] [review]
Updated patch with upstream query performed first

Here is an updated patch
Comment 3 Sebastian Dröge (slomo) 2012-06-28 12:45:35 UTC 
commit 998534a2a1f6d1943bb92fbbce1646e6c2ce3cf0
Author: David Corvoysier <david.corvoysier@orange.com>
Date:   Thu Jun 28 11:47:20 2012 +0200

    isomp4: Allow duration queries to be forwarded upstream
    
    When receiving a duration query for TIME format, try to query upstream, and only if upstream fails fall back to qtdemux duration handling.