After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678749 - use variable in Makefile.introspection for adding C includes
use variable in Makefile.introspection for adding C includes
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: build
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-06-25 02:40 UTC by Evan Nemerson
Modified: 2017-02-16 22:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Makefile.introspection: use variable for C includes (1.61 KB, patch)
2012-06-25 02:40 UTC, Evan Nemerson 		committed Details | Review

Description Evan Nemerson 2012-06-25 02:40:49 UTC 
Created attachment 217161 [details] [review]
Makefile.introspection: use variable for C includes

Right now the --c-include flag(s) have to be added to *_SCANNERFLAGS.  This is especially cumbersome when there are multiple C includes.
Comment 1 Colin Walters 2013-02-09 22:32:05 UTC 
Review of attachment 217161 [details] [review]:

s/Add/use/ in the patch description please; it's a lot clearer I think.

Otherwise, looks fine - the only caveat is that consumers might not realize they're depending on a new g-i feature.
Comment 2 Evan Nemerson 2013-02-15 09:04:29 UTC 
(In reply to comment #1)
> Review of attachment 217161 [details] [review]:
> 
> s/Add/use/ in the patch description please; it's a lot clearer I think.

Just to be clear, you meant s/use/add/, right?

> Otherwise, looks fine - the only caveat is that consumers might not realize
> they're depending on a new g-i feature.

True.  I will hold off on using this (or documenting it on the wiki) until at least next cycle.
Comment 3 André Klapper 2015-02-07 17:16:29 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]