After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678626 - Port cookies to WebKit2
Port cookies to WebKit2
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 678610
 
 
Reported: 2012-06-22 12:16 UTC by Carlos Garcia Campos
Modified: 2012-07-04 11:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (11.94 KB, patch)
2012-06-22 12:16 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2012-06-22 12:16:26 UTC 
Created attachment 217021 [details] [review]
Patch

Use WebKit2 cookies API instead of using libsoup directly.
Comment 1 Xan Lopez 2012-07-04 11:09:08 UTC 
Review of attachment 217021 [details] [review]:

I strongly dislike the PDM code in general, and it seems we'll most certainly want to get rid of it anyway, but for now let's just push everything since the important bits are in EphyEmbedPrefs and EphyEmbedSingle.

::: src/pdm-dialog.c
@@ +1028,3 @@
+	}
+
+	/* the array items has been consumed, so we need only to free the array */

Capitalization and a period.

@@ +1107,3 @@
 {
+#ifdef HAVE_WEBKIT2
+	char *domain = (char *) data;

This is the wrong style but since the file is already using it elsewhere I guess it does not matter.
Comment 2 Carlos Garcia Campos 2012-07-04 11:14:08 UTC 
Yes, I'm trying to follow the style of the file I'm modifying.