After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678616 - Port about handlers to WebKit2
Port about handlers to WebKit2
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 678610
 
 
Reported: 2012-06-22 09:25 UTC by Carlos Garcia Campos
Modified: 2012-06-26 12:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Move about handlers to a new file (19.89 KB, patch)
2012-06-22 09:25 UTC, Carlos Garcia Campos
committed Details | Review
Patch (1.85 KB, patch)
2012-06-22 09:25 UTC, Carlos Garcia Campos
committed Details | Review

Description Carlos Garcia Campos 2012-06-22 09:25:23 UTC
Created attachment 217011 [details] [review]
Move about handlers to a new file

WebKit2 API makes a lot easier to implement about handlers.
Comment 1 Carlos Garcia Campos 2012-06-22 09:25:40 UTC
Created attachment 217012 [details] [review]
Patch
Comment 2 Xan Lopez 2012-06-26 12:13:15 UTC
Review of attachment 217011 [details] [review]:

OK to commit with these small things fixed.

::: embed/ephy-about-handler.c
@@ +21,3 @@
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif

We really don't contemplate the case where config.h is not present, and we use "config.h" everywhere not <config.h> (since it's a local header?).

@@ +126,3 @@
+    g_string_append (data_str, memory);
+    g_free (memory);
+  }

I suspect about:memory is going to be fairly useless in WK2 (since it won't count the web process?), not sure if it's worth adding a note or disabling it somehow.

@@ +186,3 @@
+
+GString *
+ephy_about_handler_handle (const gchar *about)

s/gchar/char/

::: embed/ephy-about-handler.h
@@ +5,3 @@
+
+#ifndef EPHY_ABOUT_HANDLER_H
+#define EPHY_ABOUT_HANDLER_H 1

Drop the '1'.

@@ +12,3 @@
+#define EPHY_ABOUT_SCHEME_LEN 10
+
+GString *ephy_about_handler_handle (const gchar *about);

s/gchar/char/
Comment 3 Xan Lopez 2012-06-26 12:15:25 UTC
Review of attachment 217012 [details] [review]:

Neat.
Comment 4 Carlos Garcia Campos 2012-06-26 12:32:21 UTC
(In reply to comment #2)
> Review of attachment 217011 [details] [review]:
> 
> OK to commit with these small things fixed.
> 
> ::: embed/ephy-about-handler.c
> @@ +21,3 @@
> +#ifdef HAVE_CONFIG_H
> +#include <config.h>
> +#endif
> 
> We really don't contemplate the case where config.h is not present, and we use
> "config.h" everywhere not <config.h> (since it's a local header?).

Sure, I copied ephy-request-about.c because it contained most of this code, and it already had that.

> @@ +126,3 @@
> +    g_string_append (data_str, memory);
> +    g_free (memory);
> +  }
> 
> I suspect about:memory is going to be fairly useless in WK2 (since it won't
> count the web process?), not sure if it's worth adding a note or disabling it
> somehow.

Well, we can just improve it later to show memory of web and plugin processes, I guess.

> @@ +186,3 @@
> +
> +GString *
> +ephy_about_handler_handle (const gchar *about)
> 
> s/gchar/char/

Done.

> ::: embed/ephy-about-handler.h
> @@ +5,3 @@
> +
> +#ifndef EPHY_ABOUT_HANDLER_H
> +#define EPHY_ABOUT_HANDLER_H 1
> 
> Drop the '1'.

I copied ephy-request-about.h :-P

> @@ +12,3 @@
> +#define EPHY_ABOUT_SCHEME_LEN 10
> +
> +GString *ephy_about_handler_handle (const gchar *about);
> 
> s/gchar/char/

Done