After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678599 - Port link message to WebKit2
Port link message to WebKit2
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 678610
 
 
Reported: 2012-06-22 07:31 UTC by Carlos Garcia Campos
Modified: 2012-06-25 11:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
status message should be const (3.04 KB, patch)
2012-06-22 07:31 UTC, Carlos Garcia Campos 		committed Details | Review
Fix memory leaks (1.25 KB, patch)
2012-06-22 07:32 UTC, Carlos Garcia Campos 		committed Details | Review
Patch (2.20 KB, patch)
2012-06-22 07:32 UTC, Carlos Garcia Campos 		reviewed Details | Review
Updated patch. (2.15 KB, patch)
2012-06-25 10:59 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2012-06-22 07:31:52 UTC 
Created attachment 216998 [details] [review]
status message should be const

Use mouse-target-changed signal of WebKit2 to implement hovering-ever-link
Comment 1 Carlos Garcia Campos 2012-06-22 07:32:24 UTC 
Created attachment 216999 [details] [review]
Fix memory leaks
Comment 2 Carlos Garcia Campos 2012-06-22 07:32:40 UTC 
Created attachment 217000 [details] [review]
Patch
Comment 3 Xan Lopez 2012-06-25 09:34:53 UTC 
Review of attachment 216998 [details] [review]:

OK.
Comment 4 Xan Lopez 2012-06-25 09:40:44 UTC 
Review of attachment 216999 [details] [review]:

OK.
Comment 5 Xan Lopez 2012-06-25 09:42:44 UTC 
Review of attachment 217000 [details] [review]:

I assume this is basically untested since the hovering message is just not showing up in WK2 right?

::: embed/ephy-web-view.c
@@ +1217,3 @@
+  ephy_web_view_set_link_message (web_view,
+                                  webkit_hit_test_result_get_link_uri (hit_test_result));
+}

Nitpick, but I think I'd prefer:

const char *message = NULL;

if (is_link)
  message = get_link_uri ();

ephy_web_view_set_link_message (view, message);
Comment 6 Carlos Garcia Campos 2012-06-25 10:33:01 UTC 
(In reply to comment #5)
> Review of attachment 217000 [details] [review]:
> 
> I assume this is basically untested since the hovering message is just not
> showing up in WK2 right?

The hovered link is shown, as well as the selected item in the bf list.

> ::: embed/ephy-web-view.c
> @@ +1217,3 @@
> +  ephy_web_view_set_link_message (web_view,
> +                                  webkit_hit_test_result_get_link_uri
> (hit_test_result));
> +}
> 
> Nitpick, but I think I'd prefer:
> 
> const char *message = NULL;
> 
> if (is_link)
>   message = get_link_uri ();
> 
> ephy_web_view_set_link_message (view, message);

Ok.
Comment 7 Carlos Garcia Campos 2012-06-25 10:59:55 UTC 
Created attachment 217185 [details] [review]
Updated patch.
Comment 8 Xan Lopez 2012-06-25 11:08:41 UTC 
Review of attachment 217185 [details] [review]:

OK.