After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678596 - Port editing commands API to WebKit2
Port editing commands API to WebKit2
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 678610
 
 
Reported: 2012-06-22 06:53 UTC by Carlos Garcia Campos
Modified: 2012-06-25 10:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add helper function to update action sensitivity (2.53 KB, patch)
2012-06-22 06:53 UTC, Carlos Garcia Campos 		committed Details | Review
Patch (5.88 KB, patch)
2012-06-22 06:53 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2012-06-22 06:53:14 UTC 
Created attachment 216995 [details] [review]
Add helper function to update action sensitivity

Use WebKit2 API to run editing commands and query their availability.
Comment 1 Carlos Garcia Campos 2012-06-22 06:53:31 UTC 
Created attachment 216996 [details] [review]
Patch
Comment 2 Xan Lopez 2012-06-25 08:41:05 UTC 
Review of attachment 216995 [details] [review]:

Nice.
Comment 3 Xan Lopez 2012-06-25 08:47:13 UTC 
Review of attachment 216996 [details] [review]:

Can push with those two nitpicks fixed.

::: src/ephy-window.c
@@ +1236,3 @@
 
+#ifdef HAVE_WEBKIT2
+		CanEditCommandAsyncData *data;

I think this will give a warning about variables being declared in the middle of the method.

@@ +1240,3 @@
+		data = can_edit_command_async_data_new (window, "EditCopy", hide);
+		webkit_web_view_can_execute_editing_command (view, WEBKIT_EDITING_COMMAND_COPY, NULL,
+							     (GAsyncReadyCallback) can_edit_command_callback,

The style guide says don't use spaces between the cast type and the variable.