After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678594 - Port history to WebKit2
Port history to WebKit2
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 678610
 
 
Reported: 2012-06-22 06:43 UTC by Carlos Garcia Campos
Modified: 2012-06-25 10:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Rename webkit_construct_history_list (1.64 KB, patch)
2012-06-22 06:43 UTC, Carlos Garcia Campos 		committed Details | Review
Patch (7.65 KB, patch)
2012-06-22 06:44 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2012-06-22 06:43:54 UTC 
Created attachment 216992 [details] [review]
Rename webkit_construct_history_list

Use back forward list and navigation API
Comment 1 Carlos Garcia Campos 2012-06-22 06:44:18 UTC 
Created attachment 216993 [details] [review]
Patch
Comment 2 Xan Lopez 2012-06-25 08:32:18 UTC 
Review of attachment 216992 [details] [review]:

OK.
Comment 3 Xan Lopez 2012-06-25 08:39:20 UTC 
Review of attachment 216993 [details] [review]:

::: embed/ephy-web-view.c
@@ +1080,3 @@
 {
 #ifdef HAVE_WEBKIT2
+  /* TODO: WebKitBackForwardList is read-only in WebKit2 */

I guess we'll need an API to do this in WK2 then?
Comment 4 Carlos Garcia Campos 2012-06-25 09:17:36 UTC 
We need to decide first whether we really need/want it, and in such case add new api to WebKit2, yes.
Comment 5 Xan Lopez 2012-06-25 09:31:57 UTC 
(In reply to comment #4)
> We need to decide first whether we really need/want it, and in such case add
> new api to WebKit2, yes.

Well, clear history should really clear the b/f history, so I think we need something to do this yes.
Comment 6 Carlos Garcia Campos 2012-06-25 10:25:16 UTC 
Ah, right, I thought you were talking about API to build a new bf list. In any case, I left TODO comments for those cases, so I'll file new bug reports for those.