After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678592 - Port web settings to WebKit2
Port web settings to WebKit2
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 678610
 
 
Reported: 2012-06-22 06:23 UTC by Carlos Garcia Campos
Modified: 2012-06-25 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (7.33 KB, patch)
2012-06-22 06:23 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2012-06-22 06:23:11 UTC 
Created attachment 216990 [details] [review]
Patch

Implement web settings with WebKit2 API.
Comment 1 Xan Lopez 2012-06-25 08:13:14 UTC 
Review of attachment 216990 [details] [review]:

::: embed/ephy-embed-prefs.c
@@ +187,3 @@
+
+  return dp / di;
+}

I honestly have no clue about the fallback dpi algorithm used here, hopefully it's something that makes sense ;)