After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678532 - Port web view loading progress and feedback to WebKit2
Port web view loading progress and feedback to WebKit2
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 678610
 
 
Reported: 2012-06-21 11:58 UTC by Carlos Garcia Campos
Modified: 2012-06-24 11:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (17.58 KB, patch)
2012-06-21 11:58 UTC, Carlos Garcia Campos 		reviewed Details | Review
Add ephy_web_view_load_failed() (3.20 KB, patch)
2012-06-21 15:30 UTC, Carlos Garcia Campos 		committed Details | Review
Port web view loading progress and feedback to WebKit2 (15.10 KB, patch)
2012-06-21 15:30 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2012-06-21 11:58:10 UTC 
Created attachment 216909 [details] [review]
Patch

Now that the initial wk2 port has landed in master, port loading stuff to webkit2.
Comment 1 Xan Lopez 2012-06-21 13:42:03 UTC 
Review of attachment 216909 [details] [review]:

This looks pretty good. Can we split the addition of ephy_web_view_load_failed into a different patch? Seems it's largely orthogonal and it will reduce a bit of noise in the EphyWebView section of this patch. For extra points we'd add a unit test for that too, but I'm not going to force you to do that ;)

::: embed/ephy-web-view.c
@@ +3346,3 @@
+ *
+ * Return value: %TRUE if the page failed to load, %FALSE if it's loading
+ *  or load finished successfully

Nitpick, but there's an extra space here?
Comment 2 Carlos Garcia Campos 2012-06-21 15:30:33 UTC 
Created attachment 216938 [details] [review]
Add ephy_web_view_load_failed()
Comment 3 Carlos Garcia Campos 2012-06-21 15:30:58 UTC 
Created attachment 216939 [details] [review]
Port web view loading progress and feedback to WebKit2
Comment 4 Xan Lopez 2012-06-24 09:57:30 UTC 
Review of attachment 216938 [details] [review]:

Looks good.
Comment 5 Xan Lopez 2012-06-24 09:59:33 UTC 
Review of attachment 216939 [details] [review]:

Looks good.