After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678509 - rtmpsrc outputs truncated buffers
rtmpsrc outputs truncated buffers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.11.x
Other Linux
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-06-20 23:17 UTC by Mike Ruprecht
Modified: 2012-06-21 07:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix rtmpsrc truncation (1.03 KB, patch)
2012-06-20 23:23 UTC, Mike Ruprecht 		committed Details | Review

Description Mike Ruprecht 2012-06-20 23:17:28 UTC 
rtmpsrc outputs truncated buffers because, when enough data is read to fill the buffer, the amount read that time (todo) is set to zero before it's added to the cumulative buffer size (bsize). The buffer is then truncated to bsize resulting in lost data.
Comment 1 Mike Ruprecht 2012-06-20 23:23:43 UTC 
Created attachment 216886 [details] [review]
Patch to fix rtmpsrc truncation

This patch fixes it for me.
Comment 2 Sebastian Dröge (slomo) 2012-06-21 07:37:03 UTC 
Comment on attachment 216886 [details] [review]
Patch to fix rtmpsrc truncation

commit 96b7059d242421cba1dde21b841f4b95fb3aad0c
Author: Mike Ruprecht <mike.ruprecht@collabora.co.uk>
Date:   Wed Jun 20 17:52:13 2012 -0500

    rtmpsrc: Fix element losing data at the end of buffers
    
    rtmpsrc outputs truncated buffers because, when enough data is
    read to fill the buffer, the amount read that time (todo) is set
    to zero before it's added to the cumulative buffer size (bsize).
    The buffer is then truncated to bsize resulting in lost data.
    This patch adds todo to bsize before setting todo to zero.
    
    Fixes #678509