After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678490 - matroska-demux: fix TOC query to return FALSE if there's no TOC
matroska-demux: fix TOC query to return FALSE if there's no TOC
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-06-20 17:50 UTC by Anton Belka
Modified: 2012-06-25 09:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] matroska-demux: fixed gst_matroska_demux_query() (1017 bytes, patch)
2012-06-20 17:50 UTC, Anton Belka 		reviewed Details | Review
[PATCH] matroska-demux: fix gst_wavparse_pad_query() (1.07 KB, patch)
2012-06-21 09:44 UTC, Anton Belka 		needs-work Details | Review
[PATCH] matroska-demux: fixed gst_matroska_demux_query() (1.14 KB, patch)
2012-06-21 14:29 UTC, Anton Belka 		committed Details | Review

Description Anton Belka 2012-06-20 17:50:35 UTC 
Created attachment 216858 [details] [review]
[PATCH] matroska-demux: fixed gst_matroska_demux_query()

Fixed gst_matroska_demux_query() as in bug 677306, comment 5.
Comment 1 Sebastian Dröge (slomo) 2012-06-21 07:47:59 UTC 
Comment on attachment 216858 [details] [review]
[PATCH] matroska-demux: fixed gst_matroska_demux_query()

Please use a more descriptive commit message. Describe what exactly is fixed here :)

The patch itself is correct though
Comment 2 Anton Belka 2012-06-21 09:44:46 UTC 
Created attachment 216904 [details] [review]
[PATCH] matroska-demux: fix gst_wavparse_pad_query()

This patch fixes the following things:
* previous when requested TOC, function gst_wavparse_pad_query() always returned TRUE, but it is a mistake. If no TOC, should be returned FALSE.
* also previous if there was no TOC in demux, then created a new blank TOC.
Comment 3 Sebastian Dröge (slomo) 2012-06-21 10:19:04 UTC 
Comment on attachment 216904 [details] [review]
[PATCH] matroska-demux: fix gst_wavparse_pad_query()

Please use a more descriptive commit message. Describe what exactly is fixed here :)
Comment 4 Anton Belka 2012-06-21 14:29:07 UTC 
Created attachment 216924 [details] [review]
[PATCH] matroska-demux: fixed gst_matroska_demux_query()

Added a more descriptive commit message. :)
Comment 5 Sebastian Dröge (slomo) 2012-06-25 07:49:24 UTC 
commit c3061f434ba622b121499fed6eade88da97f61cb
Author: Anton Belka <antonbelka@gmail.com>
Date:   Thu Jun 21 17:15:11 2012 +0300

    matroskademux: Return FALSE from TOC query if no TOC exists instead of an empty TOC