After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678486 - Provide Credit in About Dialog for Significant Contributions
Provide Credit in About Dialog for Significant Contributions
Status: RESOLVED FIXED
Product: gparted
Classification: Other
Component: application
0.12.1
Other Linux
: Normal enhancement
: ---
Assigned To: gparted maintainers alias
gparted maintainers alias
Depends on:
Blocks:
 
 
Reported: 2012-06-20 15:56 UTC by Curtis Gedak
Modified: 2012-07-13 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GParted Help --> About Dialog Credits (25.24 KB, image/png)
2012-06-20 15:56 UTC, Curtis Gedak
Details

Description Curtis Gedak 2012-06-20 15:56:05 UTC
Created attachment 216850 [details]
GParted Help --> About Dialog Credits

While maintaining the GParted application, I have been remiss in providing credit in the Help --> About Dialog for significant contributors.

At some point I began tracking the contributions in the AUTHORS file, but had forgotten all about the About Dialog.  When the Credits button in the About Dialog is pressed, a list of names and email addresses is displayed under the title "Written by".  See attachment.

This bug report is to try to correct this situation.

For determination on whether to include a contributor or not, I am proposing the following criteria to define a "significant contribution":

1)  Major patch or new functionality added which exceeds 15 lines of non-trivial code.

2)  Three or more minor patches, where a minor patch is defined as less than 15 lines of code.

Using this criteria, I believe the following list of names should be included in the Credits section of the About Dialog:

   Luca Bruno
   Jérôme Dumesnil
   Markus Elfring
   Mike Fleetwood
   Curtis Gedak     -- already included
   Rogier Goossens
   Bart Harkvoort   -- already included
   Seth Heeren
   Joan Lledó
   Phillip Susi

If I have missed any names that should be included, then please let me know the name, email address, and indicate the contributions.  It is certainly possible that I have missed someone and I apologize in advance for the omission.

To keep things simple, my thoughts are to have the list in alphabetical order by last name as shown above.

I will send an email to these names at the email addresses listed in the AUTHORS file with regard to this bug report.
Comment 1 Markus Elfring 2012-06-20 16:25:25 UTC
(In reply to comment #1)
> ..., I believe the following list of names should be included
> in the Credits section of the About Dialog:

I accept your offer for further references in this dialogue.
Comment 2 Mike Fleetwood 2012-06-20 17:40:31 UTC
OK to include me in the credits.
Comment 3 Phillip Susi 2012-06-20 21:01:33 UTC
Fine by me.
Comment 4 Curtis Gedak 2012-06-30 17:33:29 UTC
I have now received permission from all of the above listed significant contributors, either via email, or in this bug report.

As a result the following updates have been committed to the git repository for inclusion in the next release of GParted:

Update AUTHORS
http://git.gnome.org/browse/gparted/commit/?id=14f48809ff846ff6ba5e6d25f4c5e053f63988d7

Reorder names and add significant contribution reminder to AUTHORS
http://git.gnome.org/browse/gparted/commit/?id=66961a905737fba0cc9b44998fe7c5b8c834d15d

Provide credit in About dialog for significant contributions (#678486)
http://git.gnome.org/browse/gparted/commit/?id=9591b2de082c271a2b7fbeb1f30c677b43d7b40b
Comment 5 Curtis Gedak 2012-07-13 16:52:23 UTC
Recognition of significant contributions has been included in GParted 0.13.0 released on July 13, 2012.

Thanks goes to everyone who has contributed to the GParted community.  We appreciate your help.