After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678468 - ephy-notebook: fix the property enabling tabs visibility
ephy-notebook: fix the property enabling tabs visibility
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-06-20 11:12 UTC by Claudio Saavedra
Modified: 2012-06-20 11:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ephy-notebook: fix the property enabling tabs visibility (4.32 KB, patch)
2012-06-20 11:12 UTC, Claudio Saavedra 		committed Details | Review

Description Claudio Saavedra 2012-06-20 11:12:32 UTC 
Right now, "show-tabs" is unused and also clashes with GtkNotebook's "show-tabs".
Comment 1 Claudio Saavedra 2012-06-20 11:12:34 UTC 
Created attachment 216817 [details] [review]
ephy-notebook: fix the property enabling tabs visibility

Replace the redundant and unused "show-tabs" with "tabs-allowed", and
allow its use to ultimately hide the tabs, regardless of the policy,
whenever the application UI deems necessary.
Comment 2 Xan Lopez 2012-06-20 11:18:55 UTC 
Review of attachment 216817 [details] [review]:

Looks good to me.
Comment 3 Claudio Saavedra 2012-06-20 11:38:15 UTC 
Attachment 216817 [details] pushed as bc1be97 - ephy-notebook: fix the property enabling tabs visibility