After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678391 - tests: no return in non-void function
tests: no return in non-void function
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other Windows
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-19 11:16 UTC by Dominique Leuenberger
Modified: 2012-06-19 11:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
interactive/touch-events: Add a missing return value (834 bytes, patch)
2012-06-19 11:19 UTC, Emmanuele Bassi (:ebassi)
committed Details | Review

Description Dominique Leuenberger 2012-06-19 11:16:04 UTC
While building 1.10.8, the open build server raises an error from the build root policy checker:

I: Program returns random data in a function
E: clutter no-return-in-nonvoid-function test-touch-events.c:78

The function in question is:
static gboolean
draw_touches (ClutterCairoTexture *canvas,
              cairo_t             *cr)
{
  g_slist_foreach (events, (GFunc) draw_touch, cr);
}
Comment 1 Emmanuele Bassi (:ebassi) 2012-06-19 11:19:44 UTC
Created attachment 216732 [details] [review]
interactive/touch-events: Add a missing return value

The draw_touches() function must return a boolean value.
Comment 2 Emmanuele Bassi (:ebassi) 2012-06-19 11:20:27 UTC
Attachment 216732 [details] pushed as b850696 - interactive/touch-events: Add a missing return value