After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678365 - 0.11: gstffmpegviddec broken
0.11: gstffmpegviddec broken
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
0.11.x
Other All
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 675359 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-06-19 04:11 UTC by Matej Knopp
Modified: 2012-06-20 06:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (2.21 KB, patch)
2012-06-19 04:11 UTC, Matej Knopp 		none Details | Review
Patch (2.90 KB, patch)
2012-06-20 01:43 UTC, Matej Knopp 		committed Details | Review

Description Matej Knopp 2012-06-19 04:11:45 UTC 
Created attachment 216718 [details] [review]
Patch

There are two problem after last port from 0.11

1. The decoder keeps getting reopened every time caps event is sent even though caps hasn't changed. I have a dynamic pipeline so the videoparser keeps getting reconfigure events on which it sends caps events. After discussing this with wtay last time the conclusion that decoder should not be reopened on same caps

2. ffmpeg decoder may only get trained on EOS. Any other time it may break frame-based multithreaded decoding.
Comment 1 Matej Knopp 2012-06-19 16:11:12 UTC 
*** Bug 675359 has been marked as a duplicate of this bug. ***
Comment 2 Matej Knopp 2012-06-20 01:43:45 UTC 
Created attachment 216775 [details] [review]
Patch

New patch, fixes all from previous patch and two memory leaks - neither input nor output frames were released.
Comment 3 Sebastian Dröge (slomo) 2012-06-20 06:40:54 UTC 
commit 17ee8113d7d47c43ba1ba20b6e154ad706736bf4
Author: Matej Knopp <Matej@new-host-5.home>
Date:   Tue Jun 19 21:41:14 2012 -0400

    ffmpegviddec: Don't reopen decoder on same caps, fix memory leaks, only drain on EOS