After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678334 - Clean up the Visual Studio projects generation in the autotools files
Clean up the Visual Studio projects generation in the autotools files
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: build
2.35.x
Other Windows
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-06-18 15:25 UTC by Fan, Chun-wei
Modified: 2015-10-07 14:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add support to autotools files to have header listings filled in automatically at "make dist" (76.27 KB, patch)
2012-06-18 15:25 UTC, Fan, Chun-wei
none Details | Review
Enhance Visual C++ projects creation with a new common autotools file (33.57 KB, patch)
2012-08-30 14:03 UTC, Fan, Chun-wei
none Details | Review
Clean up the autotools files for the Visual C++ project completion (39.11 KB, patch)
2013-01-18 04:20 UTC, Fan, Chun-wei
none Details | Review

Description Fan, Chun-wei 2012-06-18 15:25:39 UTC
Created attachment 216687 [details] [review]
Add support to autotools files to have header listings filled in automatically at "make dist"

Hi,

As it seems that GLib (and the GTK+/Clutter stack) evolves quite quickly, I think it would make sense to add support to the the autotools files to have the property sheets incorporate the list of headers to "install" during "make dist".

So, here is the patch to the GLib autotools files-I am currently doing this for GLib, GObject and GIO, as GModule and GThread generally does not normally have headers added/removed/renamed/deprecated...

I would most probably do the same for the GTK+/Clutter stack soon.

Thank you for your time!

With blessings.
Comment 1 Fan, Chun-wei 2012-08-30 14:03:28 UTC
Created attachment 222943 [details] [review]
Enhance Visual C++ projects creation with a new common autotools file

Hi,

I have heard that I should isolate the Visual C++ projects creation parts in an autotools file, so that it can be included in various projects to create the Visual C++ project files, and the Makefile.am's of various projects (glib, gobject and gio for this case) can be cleaned up quite a bit.

So, this is what I have-2 autotools files for this purpose.  One for inclusion for completing the project files for various projects and another for inclusion for completing the property sheets for the header listings to "install".

As I am not exactly an autotools export, any comments and advice on this would be greatly appreciated.

With blessings, thank you!
Comment 2 Fan, Chun-wei 2012-10-30 04:27:05 UTC
Hi,

Any advice or suggestions on this part?  Would like to make things easier for all on the maintenance of the autotools files and Visual C++ projects and property sheets.  I would like to have this kind of mechanism in the other parts of the GTK+/Clutter stack, as Behdad suggested a while ago.

With blessings, thank you for your time! :)
Comment 3 Fan, Chun-wei 2012-11-22 05:49:35 UTC
Hi Behdad,

Can I ask you to take a look at this patchset, as this is the kind of thing you were asking me to do a while ago, so that the maintenance of the autotools files would become simpler?  Sorry I have to add you to the CC list as I don't want this thing to slip into oblivion, especially as this is something that I also thought would be good to do, which we talked about a while ago.

That is, to use a centralized autotools file and include it from the Makefile.am's that would need it to complete the Visual Studio project files.

Please let me know if there are suggestions to its improvement

p.s. For Pango, since the source layout is a bit different (the main library, the Win32 library and FT2/Cairo libraries reside in the same directory), I will post a patch for it in a few days which also uses this kind of approach.

Thank you for your time!

With blessings!:)
Comment 4 Behdad Esfahbod 2012-12-10 01:25:27 UTC
Hi,

Looks like an improvement, however, I don't know about VC enough to really know what the patch is even supposed to do :).
Comment 5 Fan, Chun-wei 2012-12-10 04:09:41 UTC
Hi Behdad,

Basically what this patch does is to improve on Tor's approach in completing
the Visual Studio project files, as there are quite a bit of stuff added to glib/Makefile.am, gobject/Makefile.am and gio/Makefile.am so that the source listings in the corresponding Visual Studio project files are kept up-to-date during release as new sources (and headers) are frequently added during a development cycle.  In addition, currently as the listing of headers to "install" is maintained manually, I thought it would also be good if that could be automated as well, so that one would be less prone to the C1083: Cannot find include file 'abcde.h': No such file or directory errors, as newly-introduced headers were not copied in the process.

As we've previously talked about a while ago, you have suggested that I should work on a general-purpose autotools file/script so that it could be included by various projects, this is my approach to that as I thought that would be a good idea too, as it makes the Makefile.am's for GLib, GObject and GIO less crowded.

p.s. The updates to Pango are in bug 689949, for your references.

With blessings, thank you!
Comment 6 Fan, Chun-wei 2013-01-18 04:20:50 UTC
Created attachment 233715 [details] [review]
Clean up the autotools files for the Visual C++ project completion

Hi,

This adapts the patch to the latest changes in the autotools files, especially after the changes to them for visibility (bug 688681).

With blessings, thank you!
Comment 7 Fan, Chun-wei 2015-10-07 14:05:43 UTC
Hi,

Support for this has been added to GLib as a autotools module that can be included in various Makefile.am's for generating the Visual Studio files, so this is now obsolete, for records.

With blessings, thank you!