After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678299 - gst_base_sink_wait_eos and the GstBaseSink->wait_eos vfunc don't match
gst_base_sink_wait_eos and the GstBaseSink->wait_eos vfunc don't match
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-06-18 09:28 UTC by Evan Nemerson
Modified: 2012-06-18 09:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Evan Nemerson 2012-06-18 09:28:44 UTC 
The gst_base_sink_wait_eos function and the GstBaseSink->wait_eos virtual function don't match.  It's not a simple case of arguments not lining up--AFAICT they perform different tasks.  Beyond being difficult to deal with for Vala bindings (and likely others) this is just plain confusing, and it would be nice to get it changed before 1.0.

I'm not familiar with GStreamer, but if someone could provide some guidance regarding what the API should be I'd be willing to write the patch.
Comment 1 Wim Taymans 2012-06-18 09:45:03 UTC 
commit 927f261b1c66892a497219675891255264d6b5d6
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Mon Jun 18 11:36:25 2012 +0200

    basesink: wait_eos() -> wait()
    
    Rename gst_base_sink_wait_eos() to gst_base_sink_wait() to avoid confusion and
    introspection problems with the ::wait_eos vmethod. Also this method can be used
    to wait for other things than EOS. Update the docs a little.