GNOME Bugzilla – Bug 678268
Window does not resize properly
Last modified: 2018-05-22 11:42:03 UTC
When changing from a large board to a smaller board, the window does not show the same resizing behaviour as when changing from a small board to a larger one. When one changes from a small board to a large one, the window resizes to accommodate the larger board. On the other hand, when one has been playing on a large board and chooses a smaller board, the window does not resize, but the tiles scale to fit the larger board. The behaviour should be the same in both directions; my preference is for having the window resize to fit the board every time.
Created attachment 236381 [details] [review] Nice window resizing when switching between large and small.
Review of attachment 236381 [details] [review]: This needs to be rebased against master
Created attachment 236513 [details] [review] Window Resizing Patch (Version 2) Rebased.
Pushed, thank you!
Reopening because this doesn't always work reliably. Sometimes Mines gets permanently stuck with a big window instead of resizing reliably. I've seen this issue several times since the patch was pushed, but I still haven't figured out what triggers it.
Haven't had any trouble with this in a long time. If anyone runs into further issues, please reopen or comment.
This bug has either resurfaced, or maybe was never fixed like I thought it was.
I just tested and I am seeing consistent broken behaviour: I start at the "chose a game" screen which is a 8×8/16×16 field size. Select a 30×16 field size and the window resizes to be larger. Finish the game, then start an 8×8/16×16 field size and the window *does NOT* resize. Finish the 8×8/16×16 game and the window resizes to the 8×8/16×16 size. In other words, the window resizes when a new game on field which is bigger that the window is started or when a game on a field which is smaller than the window is finished. I am getting 100% consistency of this behaviour. In practice, the window should resize always when the user goes to the "chose a game" view (and keep the current behaviour of increasing window size for larger boards). An alternative to that behaviour is to always resize when the new game size changes from the previous game but this involves keeping track of the board size. Another alternative is to always resize when a new game is selected regardless of what the previous or new one is so that you don't track the size of the previous board.
This seems a bit broken even out of the box in 3.14.1. Maybe it's better in master? I opened Mines (all dconf settings were reset to default), chose 30x16, and the window resized to 931x615 (according to the Inspector). This size is so small that there are *scrollbars* on the mine canvas. I don't think it ever makes sense to have scrollbars.
What's the resolution of your screen? Scrollbars should only appear if there's not enough space to show the full minefield.
I suspect there's an issue with the patch in comment #3 (which first appeared in the 3.10 release).
My screen is 1280x1024, so it's more than enough to fit the 30x16 field.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-mines/issues/3.