After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678264 - actor: Make margin properties animatable
actor: Make margin properties animatable
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-17 19:57 UTC by Bastian Winkler
Modified: 2012-06-22 09:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
actor: Make margin properties animatable (9.09 KB, patch)
2012-06-17 19:57 UTC, Bastian Winkler 		committed Details | Review

Description Bastian Winkler 2012-06-17 19:57:08 UTC 
Enable implicit animations for :margin-(top|right|bottom|left)
properties.
Comment 1 Bastian Winkler 2012-06-17 19:57:10 UTC 
Created attachment 216617 [details] [review]
actor: Make margin properties animatable
Comment 2 Emmanuele Bassi (:ebassi) 2012-06-22 06:22:36 UTC 
Review of attachment 216617 [details] [review]:

looks generally okay to me. a couple of documentation fixes are needed before landing.

::: clutter/clutter-actor.c
@@ +6624,3 @@
                         0.0, G_MAXFLOAT,
                         0.0,
+                        CLUTTER_PARAM_READWRITE |

I'm on a mission to remove CLUTTER_PARAM_READWRITE and just use G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS. I don't want to do this in a lump commit, but it would be nice to replace it when adding a new flag.

@@ +16664,3 @@
   info = _clutter_actor_get_layout_info (self);
 
   if (info->margin.top != margin->top)

unrelated, but: at some point, we'll have to get rid of this, and either use memcmp() or an epsilon to do float equality checks.

@@ +16707,3 @@
  * Sets the margin from the top of a #ClutterActor.
  *
+ * The #ClutterActor:margin-top property is animatable.

this note, and the ones below, should also go in the property documentation.
Comment 3 Bastian Winkler 2012-06-22 09:40:10 UTC 
Review of attachment 216617 [details] [review]:

Thanks for reviewing. I'll modify the patch according to your suggestions and
push it to master.
Comment 4 Bastian Winkler 2012-06-22 09:43:29 UTC 
Attachment 216617 [details] pushed as d2fff6e - actor: Make margin properties animatable