After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678205 - Contact gets displayed in the wrong group
Contact gets displayed in the wrong group
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Contact List
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-16 07:12 UTC by Frederic Peters
Modified: 2012-06-19 11:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
missing groups, Olav looks like he is in the "entrouvert" group (22.96 KB, image/png)
2012-06-16 07:12 UTC, Frederic Peters 		  Details
after hide/show disconnected contacts, everything is back in order (26.85 KB, image/png)
2012-06-16 07:13 UTC, Frederic Peters 		  Details
roster-view: add_to_displayed: get the proper EmpathyRosterGroup object (1.60 KB, patch)
2012-06-19 11:30 UTC, Guillaume Desmottes 		committed Details | Review
roster-view: add_to_displayed: no need to try refiltering groups in non group mode (1023 bytes, patch)
2012-06-19 11:30 UTC, Guillaume Desmottes 		committed Details | Review

Description Frederic Peters 2012-06-16 07:12:04 UTC 
With the new contact list and groups enabled, I noticed this morning that a contact (see first attachment, Olav) was displayed under the wrong heading; showing and hiding back unconnected contacts restored the correct display. (see second attachment).
Comment 1 Frederic Peters 2012-06-16 07:12:45 UTC 
Created attachment 216554 [details]
missing groups, Olav looks like he is in the "entrouvert" group
Comment 2 Frederic Peters 2012-06-16 07:13:14 UTC 
Created attachment 216555 [details]
after hide/show disconnected contacts, everything is back in order
Comment 3 Guillaume Desmottes 2012-06-19 07:52:20 UTC 
The problem is actually that the 'GNOME' group title is not displayed.
Comment 4 Guillaume Desmottes 2012-06-19 11:30:48 UTC 
Created attachment 216733 [details] [review]
roster-view: add_to_displayed: get the proper EmpathyRosterGroup object

The contacts hash table is a group-name => EmpathyRosterContact mapping. We
need to use the self->priv->roster_groups hash to get the EmpathyRosterGroup
object which is the one we want to refilter.
Comment 5 Guillaume Desmottes 2012-06-19 11:30:50 UTC 
Created attachment 216734 [details] [review]
roster-view: add_to_displayed: no need to try refiltering groups in non group mode
Comment 6 Guillaume Desmottes 2012-06-19 11:38:20 UTC 
Attachment 216733 [details] pushed as 9479413 - roster-view: add_to_displayed: get the proper EmpathyRosterGroup object
Attachment 216734 [details] pushed as b7d71d0 - roster-view: add_to_displayed: no need to try refiltering groups in non group mode