GNOME Bugzilla – Bug 678123
Make ram and storage widgets look like mockup
Last modified: 2016-03-31 13:57:19 UTC
This is some initial work on making the widgets look like the mockup. Its partially hacky in the way we render the color bars, and the slider is read only for now. I think the slider part needs more design work and I intend to work with jimmac to make it better, but for now this is clearly better than the current state, and we should imho not spend more time to get that particular exact look.
Created attachment 216451 [details] [review] Update Gtk+ vapi file This fix is also upstream as http://git.gnome.org/browse/vala/commit/?id=9f7485cca955ef09efdda8bdd848c39e9f97ae06
Created attachment 216452 [details] [review] Add SpaceSpinner widget This can be used to select ram and disk sizes
Created attachment 216453 [details] [review] Use the new SpaceSpinner
Review of attachment 216451 [details] [review]: ACK
Review of attachment 216452 [details] [review]: Although this does indeed look more like the mockups but IMHO it doesn't look better than what we have currently. Also the inability to move/drag the slider with mouse would surely be disappointing/frustrating for user. How about we wait till you have it look and work like in the design (however it looks like after your discussion with jimmac)? In case you disagree, you might want to increase the size and color of the slider/arrow BTW as I could hardly see it. ::: src/space-spinner.vala @@ +125,3 @@ + string? rest = null; + // TODO: This should use a locale-dependent parser, not g_ascii_strtod + var fraction = text.to_double (out rest); space-spinner.vala:127.24-127.37: warning: string.to_double is deprecated. Use double.parse
*** Bug 675701 has been marked as a duplicate of this bug. ***
> space-spinner.vala:127.24-127.37: warning: string.to_double is deprecated. Use double.parse This is because vala deprecated that poorly. There is no other call that lets you get the pointer to the rest of the string.
Discussed this a bit with jimmac. He agrees that the current design to fiddly, and we need a different design. The main operations should be the slider part, with the entry being available for special needs. This means we can drop the spinbutton part, and perhaps do something similar to the blender slide-entry (see the % slider under Dimensions=>Resolution in the right sidebar of blender). This works as a slider normally, but if you click it it turns into an entry. More design work is needed on this.
For the record, the mockups have been updated a while ago https://github.com/gnome-design-team/gnome-mockups/raw/master/boxes/boxes-install5.5.png
Created attachment 227671 [details] [review] Properties: Allow properties to specify extra widget This extra widget will be placed on the row below the label and normal widget. Will be used for the ram/disk size widgets in the new design.
Created attachment 227672 [details] [review] Properties: Remove header on each page This is not in the mockups, and is not necessary. The current page is shown in the sidebar anyway.
Created attachment 227673 [details] [review] Properties: Make size sliders look more like mockups Changes: * Slider on row below label * Current value centered on label row * Show fill level * Add max and min value marks
This is one step closer. Still missing: * We get an arrow-down knob, since we have markers on the bottom. I think this is more right though. * We don't yet show a recommended size. Do we have that info anywhere? * The size labels are centered on what remains horizontally after the longest label width. This looks a bit weird. However, the mockup isn't perfectly centered either.
(In reply to comment #13) > This is one step closer. Still missing: > * We don't yet show a recommended size. Do we have that info anywhere? That info comes from libosinfo, which we can fetch easily if we keep the IDs of the installed os and installer media in domain xml. I already have patches for that but I don't think you'd like those. We need to add a nicer API to libvirt-glib for handling custom xml nodes first.
Review of attachment 227671 [details] [review]: ACK
Review of attachment 227672 [details] [review]: ACK
Review of attachment 227673 [details] [review]: ACK. I tested it and it looks good.
Attachment 227671 [details] pushed as 8e9389b - Properties: Allow properties to specify extra widget Attachment 227672 [details] pushed as 5fe145b - Properties: Remove header on each page Attachment 227673 [details] pushed as 2e2fd29 - Properties: Make size sliders look more like mockups
The behaviour of the Memory slider with respect to pg_up / pg_down is opposite to what it should be. eg., Paging up reduces the memory.
Split off the remaining issues to separate bugs, lets close this for now.