GNOME Bugzilla – Bug 678105
user-accounts: Update the realmd dbus interface to latest
Last modified: 2012-06-22 14:57:19 UTC
The changes in the realmd dbus interface are futureproofing to support cancellation. More details in realmd Git log: http://cgit.freedesktop.org/~stefw/realmd/commit/?id=af92a2df67bc2db863561b3302377728e48b1f75
Created attachment 216420 [details] [review] user-accounts: Update the realmd dbus interface to latest The changes in the realmd dbus interface are futureproofing to support cancellation.
Review of attachment 216420 [details] [review]: Wait, the client provides the unique id ? That seems suboptimal to me, wouldn't you expect the service to hand them out ? Otherwise, you get new error conditions where clients may provide non-unique ids, or even separation problems where clients ids may clash...
The service tracks the operation_id + the caller's unique dbus name. This is similar to GCancellable, where the caller passes in the cancellable. Later I'll add something like a CancelOperation method which accepts a unique name. Polkit does something similar. See CheckAuthorization and CancelCheckAuthorization: http://hal.freedesktop.org/docs/polkit/eggdbus-interface-org.freedesktop.PolicyKit1.Authority.html#eggdbus-method-org.freedesktop.PolicyKit1.Authority.CheckAuthorization Having the server provided jobs or transactions is complicated to do correctly in a non-racy manner, and not something I want to get into for realmd.
maybe I misunderstood what you meant by 'unique' then - it is just unique per-client. Thats more reasonable, ok.
Created attachment 216532 [details] [review] user-accounts: Update the realmd dbus interface to latest The changes in the realmd dbus interface are futureproofing to support cancellation. In addition during this time of interface flux, check the daemon version number to make sure we can talk to it.
Review of attachment 216532 [details] [review]: ::: panels/user-accounts/data/org.freedesktop.realmd.xml @@ +21,3 @@ + * A version number for the provider + --> + <property name="Version" type="s" access="read"/> Not a big deal, but you could just as well make this (dd) and save the parsing ?
(In reply to comment #6) > Review of attachment 216532 [details] [review]: > > ::: panels/user-accounts/data/org.freedesktop.realmd.xml > @@ +21,3 @@ > + * A version number for the provider > + --> > + <property name="Version" type="s" access="read"/> > > Not a big deal, but you could just as well make this (dd) and save the parsing > ? Because long term I want this property to be informational. I think we should only use it in gnome-control-center during the development process. Once the interface stabilizes, we'll no longer need to check this. Also (but less important) would like to support arbitrary version numbers.
Review of attachment 216532 [details] [review]: Fine with me, then.