Bug 678095 - Always enable a11y
Always enable a11y
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
:
Depends on: 678051
Blocks:
  Show dependency tree
 
Reported: 2012-06-14 11:57 UTC by Bastien Nocera
Modified: 2012-06-14 18:00 UTC (History)
2 users (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Always enable a11y (4.79 KB, patch)
2012-06-14 11:57 UTC, Bastien Nocera 		reviewed Details | Diff | Review
Always enable a11y (8.12 KB, patch)
2012-06-14 14:07 UTC, Bastien Nocera 		accepted-commit_now Details | Diff | Review
Always enable a11y (8.25 KB, patch)
2012-06-14 14:26 UTC, Bastien Nocera 		committed Details | Diff | Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Description Bastien Nocera 2012-06-14 11:57:45 UTC 
.
Comment 1 Bastien Nocera 2012-06-14 11:57:47 UTC 
Created attachment 216406 [details] [review]
Always enable a11y
Comment 2 Florian Müllner 2012-06-14 13:27:38 UTC 
Review of attachment 216406 [details] [review]:

Nice cleanup. In fact, it's so much cleanup that having separate shell-a11y.[ch] files around looks like overkill :)

::: src/shell-a11y.c
@@ +23,2 @@
 #include <string.h>
 #include <gmodule.h>

Obsolete includes
Comment 3 Bastien Nocera 2012-06-14 14:07:42 UTC 
Created attachment 216414 [details] [review]
Always enable a11y
Comment 4 Florian Müllner 2012-06-14 14:11:27 UTC 
Review of attachment 216414 [details] [review]:

::: src/main.c
@@ -305,2 @@
   shell_dbus_init (meta_get_replace_current_wm ());
-  shell_a11y_init ();

OK, though I'd prefer to leave the function in place (but have the implementation here, just as the rest of the shell_*_init() functions)
Comment 5 Bastien Nocera 2012-06-14 14:26:14 UTC 
Created attachment 216416 [details] [review]
Always enable a11y
Comment 6 Florian Müllner 2012-06-14 14:29:40 UTC 
Review of attachment 216416 [details] [review]:

Sorry, I had meant to say "commit with or without that fix" :-)
Comment 7 Bastien Nocera 2012-06-14 18:00:54 UTC 
Attachment 216416 [details] pushed as de1eafb - Always enable a11y
Note You need to log in before you can comment on or make changes to this bug.