After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678079 - [PATCH] memory leaks
[PATCH] memory leaks
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-14 08:53 UTC by Pavel Vasin
Modified: 2012-06-15 05:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ShellContactSystem: fix GeeMapIterator leak (676 bytes, patch)
2012-06-14 08:54 UTC, Pavel Vasin 		committed Details | Review
shell-util: fix GFile leak (650 bytes, patch)
2012-06-14 08:55 UTC, Pavel Vasin 		committed Details | Review
ShellContactSystem: fix GSList leak (759 bytes, patch)
2012-06-14 08:56 UTC, Pavel Vasin 		committed Details | Review
ShellContactSystem: fix GSList of utf8 leak (702 bytes, patch)
2012-06-14 08:56 UTC, Pavel Vasin 		committed Details | Review
st-texture-cache: fix GtkIconInfo leak (748 bytes, patch)
2012-06-14 08:57 UTC, Pavel Vasin 		committed Details | Review

Description Pavel Vasin 2012-06-14 08:53:37 UTC 
All patches are actual for master and 3.4
Comment 1 Pavel Vasin 2012-06-14 08:54:31 UTC 
Created attachment 216390 [details] [review]
ShellContactSystem: fix GeeMapIterator leak
Comment 2 Pavel Vasin 2012-06-14 08:55:17 UTC 
Created attachment 216391 [details] [review]
shell-util: fix GFile leak
Comment 3 Pavel Vasin 2012-06-14 08:56:07 UTC 
Created attachment 216392 [details] [review]
ShellContactSystem: fix GSList leak
Comment 4 Pavel Vasin 2012-06-14 08:56:51 UTC 
Created attachment 216393 [details] [review]
ShellContactSystem: fix GSList of utf8 leak
Comment 5 Pavel Vasin 2012-06-14 08:57:43 UTC 
Created attachment 216394 [details] [review]
st-texture-cache: fix GtkIconInfo leak
Comment 6 Rui Matos 2012-06-14 09:39:22 UTC 
Review of attachment 216391 [details] [review]:

Yes
Comment 7 Rui Matos 2012-06-14 09:42:37 UTC 
Review of attachment 216392 [details] [review]:

Yes
Comment 8 Rui Matos 2012-06-14 09:45:44 UTC 
Review of attachment 216393 [details] [review]:

Yes
Comment 9 Rui Matos 2012-06-14 09:48:41 UTC 
Review of attachment 216394 [details] [review]:

Yes
Comment 10 Rui Matos 2012-06-14 09:50:29 UTC 
Review of attachment 216390 [details] [review]:

This seems good although I'm not 100% sure on the vala semantics of the code where this instance comes from. Anyone?
Comment 11 Jasper St. Pierre (not reading bugmail) 2012-06-14 20:04:14 UTC 
Review of attachment 216390 [details] [review]:

Yes, this is correct.
Comment 12 Jasper St. Pierre (not reading bugmail) 2012-06-14 20:04:30 UTC 
Pavel, do you need somebody to push these patches for you?
Comment 13 Pavel Vasin 2012-06-15 03:45:26 UTC 
(In reply to comment #12)
> Pavel, do you need somebody to push these patches for you?

Yes. Somebody please push.
Comment 14 Jasper St. Pierre (not reading bugmail) 2012-06-15 05:05:37 UTC 
Attachment 216390 [details] pushed as 1cf2bb6 - ShellContactSystem: fix GeeMapIterator leak
Attachment 216391 [details] pushed as 447246d - shell-util: fix GFile leak
Attachment 216392 [details] pushed as 2b34978 - ShellContactSystem: fix GSList leak
Attachment 216393 [details] pushed as 201dc05 - ShellContactSystem: fix GSList of utf8 leak
Attachment 216394 [details] pushed as 7524210 - st-texture-cache: fix GtkIconInfo leak


Thanks for the patches, Pavel!