GNOME Bugzilla – Bug 678045
Fix compile-time warnings
Last modified: 2012-10-11 13:27:42 UTC
Unused variables and discarding 'const' qualifier.
Created attachment 216315 [details] [review] droute: Fix compile-time warnings
Created attachment 216316 [details] [review] Remove empty spi_cache_dispose() function
Created attachment 216317 [details] [review] Fix unused functions when compiling w/o debug
Created attachment 216318 [details] [review] Fix compile-time warnings Unused variables, assignment used as truth values and unused functions.
Why did you remove the emit_event calls from toplevel_added_event_listener and toplevel_removed_event_listener? Was this intentional?
(In reply to comment #5) > Why did you remove the emit_event calls from toplevel_added_event_listener and > toplevel_removed_event_listener? Was this intentional? It was intentional, as the functions were unused.
Comment on attachment 216318 [details] [review] Fix compile-time warnings Attachment 216318 [details] pushed as 17b84f5 - Fix compile-time warnings
Any updates on the other 3 patches?
Comment on attachment 216315 [details] [review] droute: Fix compile-time warnings I apologize; I probably meant to accept these patches and forgot to. They all look fine to me. Thanks.
All pushed to master, thanks. Attachment 216315 [details] pushed as 0473224 - droute: Fix compile-time warnings Attachment 216316 [details] pushed as e169ae3 - Remove empty spi_cache_dispose() function Attachment 216317 [details] pushed as b1a9edd - Fix unused functions when compiling w/o debug